Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks quick edit functionality #1

Closed
Rarst opened this issue Oct 8, 2012 · 3 comments
Closed

Breaks quick edit functionality #1

Rarst opened this issue Oct 8, 2012 · 3 comments

Comments

@Rarst
Copy link

Rarst commented Oct 8, 2012

Enabling plugin mangles quick edit functionality of post list screens in admin.
@franz-josef-kaiser
Copy link
Owner

Traced down to current_admin_globals :: markup().

Removing the MarkUp fixes it. From a var_dump() of the MarkUp and a short run of manual beautification, there's nothing that seems to be wrong. All tags are opened/closed properly.

@franz-josef-kaiser
Copy link
Owner

Traced down to using the wrong quotes around the string for sprintf().

@franz-josef-kaiser
Copy link
Owner

Done in this 139e930 commit. Sadly it's now not as pretty anymore. WP uses $( ".widefat" ) to trigger stuff all over different files. Sad, but what shall I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franz-josef-kaiser @Rarst