Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axis-chart-utils.js #282

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Update axis-chart-utils.js #282

merged 1 commit into from
Apr 30, 2020

Conversation

scottfr
Copy link

@scottfr scottfr commented Apr 19, 2020

Fix issue with overlapping labels on series charts.

Explanation About What Code Achieves:

Fixes the series chart overlapping label issue here:

#158

The issue was caused by the label overlapping logic only showing every Nth label. However N could change for each unique label length resulting in strange overlaps when the label length would change.

We now just choose one label length (the longest label) and use that throughout for spacing.

Screenshots/GIFs:

See here for a screenshot of the issue:

#158

Steps To Test:

Create a series chart with labels that have a different number of characters. View before and after this change

TODOs:
  • None

Fix issue with overlapping labels on seriese charts.
@coveralls
Copy link

coveralls commented Apr 19, 2020

Pull Request Test Coverage Report for Build 157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%

Totals Coverage Status
Change from base Build 156: 0.0%
Covered Lines: 29
Relevant Lines: 62

💛 - Coveralls

@scmmishra scmmishra merged commit 3e71dd3 into frappe:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants