fix: Navigation fix using tabs in inline filters (#75)

frappe · Jul 5, 2019 · 3712aaa · 3712aaa
1 parent 63bfb56
commit 3712aaa
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/cellmanager.js b/src/cellmanager.js
@@ -54,13 +54,6 @@ export default class CellManager {
                 this.deactivateEditing();
             }
         });
-        this.keyboard.on('tab, shift+tab', (e) => {
-            if (this.$editingCell) {
-                // tab keypress on editing cell
-                this.deactivateEditing();
-                this.focusCellInDirection(e.shiftKey ? 'left' : 'right');
-            }
-        });
     }
 
     bindKeyboardNav() {
@@ -647,8 +640,10 @@ export default class CellManager {
     }
 
     focusCellInDirection(direction) {
-        if (!this.$focusedCell || this.$editingCell) {
+        if (!this.$focusedCell) {
             return false;
+        } else if (this.$editingCell && ['tab', 'shift+tab'].includes(direction)) {
+            this.deactivateEditing();
         }
 
         let $cell = this.$focusedCell;