Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-currency per account #1002

Closed
26 of 27 tasks
rmehta opened this issue Oct 26, 2013 · 36 comments
Closed
26 of 27 tasks

Multi-currency per account #1002

rmehta opened this issue Oct 26, 2013 · 36 comments
Assignees
Milestone

Comments

@rmehta
Copy link
Member

rmehta commented Oct 26, 2013

  • Add Account Currency to Account & Party
  • Add Debit (in Alt Currency) and Credit (in Alt Currency) to GL Entry
  • [validation] Do not allow currency to change if any transaction has been made for both Party and Account
  • Currency input on creation of account from Chart of Accounts
  • In GL Entry posting, also post in alternate currency if party and account currencies are alt and match
  • Currency in Party and Account (Debtors) must match
  • In Journal Entry, on selection of account, select currency for the row.
  • In Journal Entry, Sales Invoice, Purchase Invoice post to default currency (DC) (based on exchange rate) and Account Currency (AC)
  • Fetch Exchange rate in Journal Entry based on average exchange_rate in case of inter-bank transfer, otherwise fetch current exchange rate
  • Currency in transactions must be either in party currency or company currency
  • All selected accounts in a transaction must be with transaction currency or in company currency
  • Invoice outstanding, advance amount in party account currency
  • Invoice paid amount and write off amount in both company currency and transaction currency
  • Patch for Outstanding, Paid, advance, write-off amount
  • Payment Tool in party currency
  • Accounting Currency in Customer / Supplier, patch for existing records
  • Force to mention Receivable / Payable account in Customer/Supplier, if party account currency is different from company currency
  • Show Receivable / Payable accounts, in accounting currency for customer/supplier and validate
  • Update "Advance Paid" in Order, based on party account currency, validate with grand total based on currency
  • Test Case
  • Patch
    • Set currency in Account, GL Entry, Journal Entry
    • Update base_paid_amount, base_write_off_amount, party_account_currency value in sales / purchase invoice
    • Update Exchange Rate, debit/credit in account currency in Journal Entry and GL Entry
    • Set Accounting Currency for party
    • Set party account if default currency of party other than company's default currency
  • Reports: Show Balance in account currency if filtered by account and account currency is different from company currency
    • General Ledger
    • Receivable
    • Payable
  • Reports: Show all balances in company currency based on exchange rate as on filter
    • Trial Balance
    • Balance Sheet
    • P&L
    • Financial Analytics
  • Update manual
  • Add multi currency data in erpnext-demo
  • Set currency and exchange rate based on customer in Quotation while making from Opportunity
  • Set currency and exchange rate based on Supplier in Supplier Quotation / Purchase Order while making from Material Request

Inter-currency Conversion

AccountDebitCreditDebit (Alt)Credit (Alt)
Paypal (USD)6000$100
Bank (INR)6100
Exchange Gain / Loss (INR)100

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@viktor-zhuromskyy
Copy link

+1

1 similar comment
@bobzz-zone
Copy link
Contributor

+1

@bobzz-zone
Copy link
Contributor

when this can be done?

@rmehta rmehta modified the milestones: ERPNext 5.0, Feedback Oct 2013 Oct 17, 2014
@rmehta
Copy link
Member Author

rmehta commented Oct 17, 2014

Added it in 5.0

@bobzz-zone
Copy link
Contributor

when it will be released ? since i need that in the implementation....

@aram-k
Copy link

aram-k commented Nov 25, 2014

Good day. we have been testing erpnext for the past 15 days and our main concern now is the multicurrency. is it available on the current online version of erpnext?

@aram-k
Copy link

aram-k commented Jan 14, 2015

+100

@viktor-zhuromskyy
Copy link

Whats the safest way to update Grappe to 5.0 and ERP Next on top of it? My previous attempts failed with broken ERPNext instances :(

@nabinhait nabinhait self-assigned this Feb 2, 2015
@bobzz-zone
Copy link
Contributor

how this feature progress?

@anandpdoshi
Copy link
Contributor

In development for v5.

@nabinhait nabinhait modified the milestones: ERPNext 5.1, ERPNext 5.0 Mar 4, 2015
@bobzz-zone
Copy link
Contributor

when is the expected done time for this?....im really wait for it...

@gnunicorn
Copy link

@nabinhait is that in 5.0 now? When is 5.0 supposed to be released? If it is not in 5.0, how much work do you believe it is? We might consider making a PR if that would be welcomed ...

@bobzz-zone
Copy link
Contributor

when this will ready to use?.... im really love too see this, and really waiting for it

@nabinhait
Copy link
Member

Will work on it soon. Have already completed all dependent ground work.

@abdur-rehman-pk
Copy link

when this feature will be added on erpnext verion 5

@bobzz-zone
Copy link
Contributor

Hi, how is the news for this issue?.....thanks

@bobzz-zone
Copy link
Contributor

i wonder how is it going ?

@bobzz-zone
Copy link
Contributor

@abdur-rehman-pk , @ligthyear , @aram-k , @devdesco-ceo to support this issues please place bounty on it.... i did myself already , here my thread on forum https://discuss.frappe.io/t/multi-currency-feature/6553

@rmehta
Copy link
Member Author

rmehta commented Aug 14, 2015

@bobzz-zone we have started this project. Should be done by next week.

nabinhait pushed a commit to nabinhait/erpnext that referenced this issue Aug 18, 2015
nabinhait pushed a commit to nabinhait/erpnext that referenced this issue Aug 19, 2015
@bobzz-zone
Copy link
Contributor

im really wait for the release..... if i may... can i pull to the current version?.... i really want to check how its gonna work

nabinhait pushed a commit to nabinhait/erpnext that referenced this issue Aug 27, 2015
@nabinhait
Copy link
Member

@bobzz-zone We have completed the major development. Now it is in testing phase, some final touch required. You can check https://github.com/nabinhait/erpnext/tree/multi-currency.

@sinaisix
Copy link

Great. We're patiently waiting.

@bobzz-zone
Copy link
Contributor

@nabinhait i think in currency exchange for a date there should be 4 rates ,
1 for buying transaction
2 for selling transaction
3 for buying reports rate
4 for selling report rate
or you might just make 1 rate for the report its also fine , because if we just have 1 rates for all its not applicable , seeling and buying rates is ussually different and also transaction rates and report rates is different also

anyway i cant install the branch its showing error :
_mysql_exceptions.OperationalError: (1054, "Unknown column 'reference_type' in 'field list'")

@nabinhait
Copy link
Member

I didn't get your point. Can you please elaborate why there should be 4
different exchange rate?
On 28 Aug 2015 09:31, "bobzz-zone" notifications@github.com wrote:

@nabinhait https://github.com/nabinhait i think in currency exchange
for a date there should be 4 rates ,
1 for buying transaction
2 for selling transaction
3 for buying reports rate
4 for selling report rate
or you might just make 1 rate for the report its also fine , because if we
just have 1 rates for all its not applicable , seeling and buying rates is
ussually different and also transaction rates and report rates is different
also

anyway i cant install the branch its showing error :
_mysql_exceptions.OperationalError: (1054, "Unknown column
'reference_type' in 'field list'")


Reply to this email directly or view it on GitHub
#1002 (comment).

@bobzz-zone
Copy link
Contributor

@nabinhait we should have 4 or at least 3....
because....
like money exchanger we have sell rates and buy rates
but for reporting or counting our assets we should have report rates or it will be better if there is sell report rates and buy report rates..

did you get my point ?

@andiyan1
Copy link

Dear Team,

Thanks for the update on the currency system. i believe this is a very important feature erpnext should have. I am willing to sponsor for development.

IMHO, for the currency rate i think it should be handled like stock item. we can value the currency based on FIFO or Moving average. so when we buy dollar or other currency, we can have 2 rate.

one is for buying rate, one another is for average buying rate. so we can expect to have currency gain or currency loss from the transaction.

Thanks and best regards

Anton

@bobzz-zone
Copy link
Contributor

@nabinhait anyway if its possible please add currency date , so we can see the used currency history aswell

@jof2jc
Copy link
Contributor

jof2jc commented Aug 29, 2015

I think it's better to have option in feature setup to on/off multicurrency cause this feature is mostly needed by medium businesses. So others can just set it off when not using it to keep everything simple.

@bobzz-zone
Copy link
Contributor

@nabinhait about what im suggesting... is that possible ?

@bobzz-zone
Copy link
Contributor

and how about the currency exchange loss or profit?... because there should be a calculation for that

@bobzz-zone
Copy link
Contributor

@nabinhait how is it ? ...

@nabinhait
Copy link
Member

@bobzz-zone Almost completed...

@bobzz-zone
Copy link
Contributor

@nabinhait i think the one at the git hub i cant manage to test it....i dont know where was the changed..... up tried to update but i cant see any logs for it... is the git not updated ?

@nabinhait
Copy link
Member

I pushed it in my own repo https://github.com/nabinhait/erpnext/tree/multi-currency, will send a pull request today.

@bobzz-zone
Copy link
Contributor

Yap, i did already git checkout -b multi-currency but there is no changes....
ill wait for the update today then.... thanks

@bobzz-zone
Copy link
Contributor

@nabinhait is it merged already?....just updated but didnt see any changes

@rmehta rmehta closed this as completed Sep 16, 2015
@frappe frappe locked and limited conversation to collaborators Oct 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests