Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set available-for-use date if missing #30838

Merged
merged 5 commits into from May 6, 2022
Merged

fix: Set available-for-use date if missing #30838

merged 5 commits into from May 6, 2022

Conversation

GangaManoj
Copy link
Contributor

Issue:

On trying to submit an Asset Repair, the linked Asset doc also gets saved as repairs can modify the value and depreciation schedule of an Asset. However, this can sometimes raise an error when the linked Asset is very old, as a mandatory field, available_for_use_date, which was only introduced a few years ago, will not have any value.

Fix:

Set purchase_date as available_for_use_date for all Assets that are missing it.

Reference Issue

ISS-21-22-14573

@nextchamp-saqib nextchamp-saqib merged commit bf2eaec into frappe:version-13-hotfix May 6, 2022
frappe-pr-bot pushed a commit that referenced this pull request May 10, 2022
@frappe-bot
chore(release): Bumped to Version 13.29.0
974f2a8 
# [13.29.0](v13.28.0...v13.29.0) (2022-05-10)

### Bug Fixes

* Consider paryt and party type as well in group by consolidated view ([189fc89](189fc89))
* disable form save on naming series tool ([#30909](#30909)) ([#30910](#30910)) ([d60a6cb](d60a6cb))
* double future qty updates ([0db3013](0db3013))
* HSN-wise-summary of outward supplies Updated Report ([3637525](3637525))
* Ignore loan repayments made from salary slip ([b7e1d40](b7e1d40))
* **india:** invoice type for a debit note e-invoice ([#30948](#30948)) ([c46add3](c46add3))
* **india:** keyerror while generating e-way bill from an e-invoice ([#30879](#30879)) ([98d799e](98d799e))
* **india:** re-arrange e-way bill dialog fields ([#30941](#30941)) ([7ce5c93](7ce5c93))
* Item Alternative Test ([964de1f](964de1f))
* patch for renaming membership settings ([#30929](#30929)) ([9189653](9189653))
* **pos:** creating pos returns resets pricing rules & discounts ([#30936](#30936)) ([a0e39db](a0e39db))
* remove check for already allocated earned leaves ([#30931](#30931)) ([#30932](#30932)) ([80f7d66](80f7d66))
* Remove commit from stock entry test. The assertion is not important ([c449b35](c449b35))
* Set available-for-use date if missing ([#30838](#30838)) ([bf2eaec](bf2eaec))
* show group warehouse in Sales Order ([#30891](#30891)) ([#30893](#30893)) ([c458e14](c458e14))
* Show linked time sheets in sales invoice dashboard ([4f4af52](4f4af52))
* sort before picking next stock reco ([e27fb58](e27fb58))
* subtract change_amount from paid_amount field on POS Register ([#30937](#30937)) ([b7e873b](b7e873b))
* Unlink and delete batch created from stock reco on cancel ([fc35323](fc35323))
* Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](d53228b))

### Features

* **HR:** Leave Type configuration to allow over allocation (backport [#30940](#30940)) ([#30944](#30944)) ([64440fc](64440fc))
* **india:** cancel e-way bill is enabled with e-invoicing APIs. ([#30924](#30924)) ([4ef2ffd](4ef2ffd))
* **india:** generate qrcode button for e-invoice ([#30946](#30946)) ([7bd5b2b](7bd5b2b))
* **india:** store e-way bill auto calculated distance in sales invoice ([#30923](#30923)) ([b96f156](b96f156))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

deepeshgarg007 pushed a commit to deepeshgarg007/erpnext that referenced this pull request May 13, 2022
@frappe-bot @deepeshgarg007
chore(release): Bumped to Version 13.29.0
7369db5 
# [13.29.0](frappe/erpnext@v13.28.0...v13.29.0) (2022-05-10)

### Bug Fixes

* Consider paryt and party type as well in group by consolidated view ([189fc89](frappe@189fc89))
* disable form save on naming series tool ([frappe#30909](frappe#30909)) ([frappe#30910](frappe#30910)) ([d60a6cb](frappe@d60a6cb))
* double future qty updates ([0db3013](frappe@0db3013))
* HSN-wise-summary of outward supplies Updated Report ([3637525](frappe@3637525))
* Ignore loan repayments made from salary slip ([b7e1d40](frappe@b7e1d40))
* **india:** invoice type for a debit note e-invoice ([frappe#30948](frappe#30948)) ([c46add3](frappe@c46add3))
* **india:** keyerror while generating e-way bill from an e-invoice ([frappe#30879](frappe#30879)) ([98d799e](frappe@98d799e))
* **india:** re-arrange e-way bill dialog fields ([frappe#30941](frappe#30941)) ([7ce5c93](frappe@7ce5c93))
* Item Alternative Test ([964de1f](frappe@964de1f))
* patch for renaming membership settings ([frappe#30929](frappe#30929)) ([9189653](frappe@9189653))
* **pos:** creating pos returns resets pricing rules & discounts ([frappe#30936](frappe#30936)) ([a0e39db](frappe@a0e39db))
* remove check for already allocated earned leaves ([frappe#30931](frappe#30931)) ([frappe#30932](frappe#30932)) ([80f7d66](frappe@80f7d66))
* Remove commit from stock entry test. The assertion is not important ([c449b35](frappe@c449b35))
* Set available-for-use date if missing ([frappe#30838](frappe#30838)) ([bf2eaec](frappe@bf2eaec))
* show group warehouse in Sales Order ([frappe#30891](frappe#30891)) ([frappe#30893](frappe#30893)) ([c458e14](frappe@c458e14))
* Show linked time sheets in sales invoice dashboard ([4f4af52](frappe@4f4af52))
* sort before picking next stock reco ([e27fb58](frappe@e27fb58))
* subtract change_amount from paid_amount field on POS Register ([frappe#30937](frappe#30937)) ([b7e873b](frappe@b7e873b))
* Unlink and delete batch created from stock reco on cancel ([fc35323](frappe@fc35323))
* Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](frappe@d53228b))

### Features

* **HR:** Leave Type configuration to allow over allocation (backport [frappe#30940](frappe#30940)) ([frappe#30944](frappe#30944)) ([64440fc](frappe@64440fc))
* **india:** cancel e-way bill is enabled with e-invoicing APIs. ([frappe#30924](frappe#30924)) ([4ef2ffd](frappe@4ef2ffd))
* **india:** generate qrcode button for e-invoice ([frappe#30946](frappe#30946)) ([7bd5b2b](frappe@7bd5b2b))
* **india:** store e-way bill auto calculated distance in sales invoice ([frappe#30923](frappe#30923)) ([b96f156](frappe@b96f156))
mergify bot pushed a commit that referenced this pull request May 15, 2022
@frappe-bot @mergify
chore(release): Bumped to Version 13.29.0
c1f47d3 
# [13.29.0](v13.28.0...v13.29.0) (2022-05-10)

### Bug Fixes

* Consider paryt and party type as well in group by consolidated view ([189fc89](189fc89))
* disable form save on naming series tool ([#30909](#30909)) ([#30910](#30910)) ([d60a6cb](d60a6cb))
* double future qty updates ([0db3013](0db3013))
* HSN-wise-summary of outward supplies Updated Report ([3637525](3637525))
* Ignore loan repayments made from salary slip ([b7e1d40](b7e1d40))
* **india:** invoice type for a debit note e-invoice ([#30948](#30948)) ([c46add3](c46add3))
* **india:** keyerror while generating e-way bill from an e-invoice ([#30879](#30879)) ([98d799e](98d799e))
* **india:** re-arrange e-way bill dialog fields ([#30941](#30941)) ([7ce5c93](7ce5c93))
* Item Alternative Test ([964de1f](964de1f))
* patch for renaming membership settings ([#30929](#30929)) ([9189653](9189653))
* **pos:** creating pos returns resets pricing rules & discounts ([#30936](#30936)) ([a0e39db](a0e39db))
* remove check for already allocated earned leaves ([#30931](#30931)) ([#30932](#30932)) ([80f7d66](80f7d66))
* Remove commit from stock entry test. The assertion is not important ([c449b35](c449b35))
* Set available-for-use date if missing ([#30838](#30838)) ([bf2eaec](bf2eaec))
* show group warehouse in Sales Order ([#30891](#30891)) ([#30893](#30893)) ([c458e14](c458e14))
* Show linked time sheets in sales invoice dashboard ([4f4af52](4f4af52))
* sort before picking next stock reco ([e27fb58](e27fb58))
* subtract change_amount from paid_amount field on POS Register ([#30937](#30937)) ([b7e873b](b7e873b))
* Unlink and delete batch created from stock reco on cancel ([fc35323](fc35323))
* Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](d53228b))

### Features

* **HR:** Leave Type configuration to allow over allocation (backport [#30940](#30940)) ([#30944](#30944)) ([64440fc](64440fc))
* **india:** cancel e-way bill is enabled with e-invoicing APIs. ([#30924](#30924)) ([4ef2ffd](4ef2ffd))
* **india:** generate qrcode button for e-invoice ([#30946](#30946)) ([7bd5b2b](7bd5b2b))
* **india:** store e-way bill auto calculated distance in sales invoice ([#30923](#30923)) ([b96f156](b96f156))

(cherry picked from commit 7369db5)

# Conflicts:
#	erpnext/__init__.py
hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 20, 2022
@frappe-bot @hrwX
chore(release): Bumped to Version 13.29.0
778b99d 
# [13.29.0](frappe/erpnext@v13.28.0...v13.29.0) (2022-05-10)

### Bug Fixes

* Consider paryt and party type as well in group by consolidated view ([189fc89](frappe@189fc89))
* disable form save on naming series tool ([frappe#30909](frappe#30909)) ([frappe#30910](frappe#30910)) ([d60a6cb](frappe@d60a6cb))
* double future qty updates ([0db3013](frappe@0db3013))
* HSN-wise-summary of outward supplies Updated Report ([3637525](frappe@3637525))
* Ignore loan repayments made from salary slip ([b7e1d40](frappe@b7e1d40))
* **india:** invoice type for a debit note e-invoice ([frappe#30948](frappe#30948)) ([c46add3](frappe@c46add3))
* **india:** keyerror while generating e-way bill from an e-invoice ([frappe#30879](frappe#30879)) ([98d799e](frappe@98d799e))
* **india:** re-arrange e-way bill dialog fields ([frappe#30941](frappe#30941)) ([7ce5c93](frappe@7ce5c93))
* Item Alternative Test ([964de1f](frappe@964de1f))
* patch for renaming membership settings ([frappe#30929](frappe#30929)) ([9189653](frappe@9189653))
* **pos:** creating pos returns resets pricing rules & discounts ([frappe#30936](frappe#30936)) ([a0e39db](frappe@a0e39db))
* remove check for already allocated earned leaves ([frappe#30931](frappe#30931)) ([frappe#30932](frappe#30932)) ([80f7d66](frappe@80f7d66))
* Remove commit from stock entry test. The assertion is not important ([c449b35](frappe@c449b35))
* Set available-for-use date if missing ([frappe#30838](frappe#30838)) ([bf2eaec](frappe@bf2eaec))
* show group warehouse in Sales Order ([frappe#30891](frappe#30891)) ([frappe#30893](frappe#30893)) ([c458e14](frappe@c458e14))
* Show linked time sheets in sales invoice dashboard ([4f4af52](frappe@4f4af52))
* sort before picking next stock reco ([e27fb58](frappe@e27fb58))
* subtract change_amount from paid_amount field on POS Register ([frappe#30937](frappe#30937)) ([b7e873b](frappe@b7e873b))
* Unlink and delete batch created from stock reco on cancel ([fc35323](frappe@fc35323))
* Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](frappe@d53228b))

### Features

* **HR:** Leave Type configuration to allow over allocation (backport [frappe#30940](frappe#30940)) ([frappe#30944](frappe#30944)) ([64440fc](frappe@64440fc))
* **india:** cancel e-way bill is enabled with e-invoicing APIs. ([frappe#30924](frappe#30924)) ([4ef2ffd](frappe@4ef2ffd))
* **india:** generate qrcode button for e-invoice ([frappe#30946](frappe#30946)) ([7bd5b2b](frappe@7bd5b2b))
* **india:** store e-way bill auto calculated distance in sales invoice ([frappe#30923](frappe#30923)) ([b96f156](frappe@b96f156))

(cherry picked from commit 7369db5)

# Conflicts:
#	erpnext/__init__.py
anandbaburajan added a commit that referenced this pull request Mar 21, 2023
@anandbaburajan
fix: incorrect depr schedules after asset repair [v14] (#34527)
560df63 
* fix: backport missing changes from #30838

* fix: incorrect schedule after repair
frappe-pr-bot pushed a commit that referenced this pull request Mar 21, 2023
@frappe-bot
chore(release): Bumped to Version 14.19.0
e271935 
# [14.19.0](v14.18.3...v14.19.0) (2023-03-21)

### Bug Fixes

* **client:** Amount calculation for 0 qty debit notes ([#34455](#34455)) ([d24f4d2](d24f4d2))
* difference amount calculation for company currency accounts ([9ab7bff](9ab7bff))
* don't map item row having `0` qty ([7611a49](7611a49))
* E-commerce issue with Item Variants ([53c3fff](53c3fff))
* german translations ([#34312](#34312)) ([dd0c833](dd0c833))
* hide `+` button based on `Blanket Order Type` ([daa1bb8](daa1bb8))
* incorrect depr schedules after asset repair [v14] ([#34527](#34527)) ([560df63](560df63)), closes [#30838](#30838)
* Multiple accounting dimension filtering in AR/AP reports ([#34464](#34464)) ([f146479](f146479))
* Overallocation of 'qty' from Cr Notes to Parent Invoice ([848e56b](848e56b))
* patch depends on Currency Exchange Settings ([#34494](#34494)) ([4acde44](4acde44))
* POS not picking up pos profile company address instead fetch any random company address ([#34521](#34521)) ([01f4cc7](01f4cc7))
* Update account number from parent company ([#34474](#34474)) ([55d002c](55d002c))
* use max function to get default company address (backport [#34116](#34116)) ([#34452](#34452)) ([ba2fd71](ba2fd71))

### Features

* add field `Over Order Allowance (%)` in `Buying Settings` ([da915f1](da915f1))
* add field `Over Order Allowance (%)` in `Selling Settings` ([46b5ba9](46b5ba9))
* bank reconciliation and plaid changes ([#33986](#33986)) ([9b608ea](9b608ea))
* consider `over_order_allowance` while validating order qty ([932639b](932639b))
* consider `over_order_allowance` while validating sales order qty ([09b577a](09b577a))
* Support for Alternative Items in Quotation ([#33874](#33874)) ([9f7da21](9f7da21))

### Performance Improvements

* index against_sales_invoice field on DN items (backport [#34509](#34509)) ([#34510](#34510)) ([baa789b](baa789b))
anandbaburajan added a commit that referenced this pull request Mar 21, 2023
@anandbaburajan
fix: incorrect depr schedules after asset repair [develop] (#34544)
6d6a7bc 
* fix: backport missing changes from #30838

* fix: incorrect schedule after repair
babureddyks pushed a commit to babureddyks/Check_Engine that referenced this pull request Mar 28, 2023
@frappe-bot
chore(release): Bumped to Version 14.19.0
475425c 
# [14.19.0](frappe/erpnext@v14.18.3...v14.19.0) (2023-03-21)

### Bug Fixes

* **client:** Amount calculation for 0 qty debit notes ([#34455](frappe/erpnext#34455)) ([d24f4d2](frappe/erpnext@d24f4d2))
* difference amount calculation for company currency accounts ([9ab7bff](frappe/erpnext@9ab7bff))
* don't map item row having `0` qty ([7611a49](frappe/erpnext@7611a49))
* E-commerce issue with Item Variants ([53c3fff](frappe/erpnext@53c3fff))
* german translations ([#34312](frappe/erpnext#34312)) ([dd0c833](frappe/erpnext@dd0c833))
* hide `+` button based on `Blanket Order Type` ([daa1bb8](frappe/erpnext@daa1bb8))
* incorrect depr schedules after asset repair [v14] ([#34527](frappe/erpnext#34527)) ([560df63](frappe/erpnext@560df63)), closes [#30838](frappe/erpnext#30838)
* Multiple accounting dimension filtering in AR/AP reports ([#34464](frappe/erpnext#34464)) ([f146479](frappe/erpnext@f146479))
* Overallocation of 'qty' from Cr Notes to Parent Invoice ([848e56b](frappe/erpnext@848e56b))
* patch depends on Currency Exchange Settings ([#34494](frappe/erpnext#34494)) ([4acde44](frappe/erpnext@4acde44))
* POS not picking up pos profile company address instead fetch any random company address ([#34521](frappe/erpnext#34521)) ([01f4cc7](frappe/erpnext@01f4cc7))
* Update account number from parent company ([#34474](frappe/erpnext#34474)) ([55d002c](frappe/erpnext@55d002c))
* use max function to get default company address (backport [#34116](frappe/erpnext#34116)) ([#34452](frappe/erpnext#34452)) ([ba2fd71](frappe/erpnext@ba2fd71))

### Features

* add field `Over Order Allowance (%)` in `Buying Settings` ([da915f1](frappe/erpnext@da915f1))
* add field `Over Order Allowance (%)` in `Selling Settings` ([46b5ba9](frappe/erpnext@46b5ba9))
* bank reconciliation and plaid changes ([#33986](frappe/erpnext#33986)) ([9b608ea](frappe/erpnext@9b608ea))
* consider `over_order_allowance` while validating order qty ([932639b](frappe/erpnext@932639b))
* consider `over_order_allowance` while validating sales order qty ([09b577a](frappe/erpnext@09b577a))
* Support for Alternative Items in Quotation ([#33874](frappe/erpnext#33874)) ([9f7da21](frappe/erpnext@9f7da21))

### Performance Improvements

* index against_sales_invoice field on DN items (backport [#34509](frappe/erpnext#34509)) ([#34510](frappe/erpnext#34510)) ([baa789b](frappe/erpnext@baa789b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees

@nextchamp-saqib nextchamp-saqib

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GangaManoj @frappe-pr-bot @nextchamp-saqib @deepeshgarg007