Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase and Sales Rate not getting Updated. #35933

Closed
nitin-anantpranali opened this issue Jun 29, 2023 · 7 comments · Fixed by #40333
Closed

Purchase and Sales Rate not getting Updated. #35933

nitin-anantpranali opened this issue Jun 29, 2023 · 7 comments · Fixed by #40333
Assignees
Labels

Comments

@nitin-anantpranali
Copy link

Information about bug

We have one Setting in Stock Settings > Price List Defaults >
Update Existing Price List Rate

By using this checkbox ideally the Buying Rate should get updated while Purchase Documents and Selling Rate while passing the Sales Documents.

But its not working.

Module

buying, selling

Version

Frappe Chat: v0.0.1 (HEAD)
ERPNext: v14.27.9 (HEAD)
Frappe Framework: v14.40.0 (HEAD)
Frappe HR: v14.4.4 (HEAD)
India Compliance: v14.10.2 (HEAD)
Payments: v0.0.1 (HEAD)

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

@ahmedbahgattt
Copy link

same problem,

@alirayya1
Copy link

same

@deepspeccode
Copy link

when is this going to be fixed?

@deepspeccode
Copy link

I need this fixed please?

@billj9000
Copy link

billj9000 commented Oct 28, 2023

It seems to me that the function to update the price, insert_item_price(), is only called if the price does not already exist:
https://github.com/frappe/erpnext/blob/ce748cec3a6e2b289878bf5d57ac6db3cb851618/erpnext/stock/get_item_details.py#L817C1-L822C1

This works fine for adding a new price if auto_insert_price_list_rate_if_missing is set. However, it doesn't work for updating an existing price if update_existing_price_list_rate is set because the function to do it is not called.

I would also like to see this fixed. However, if it is intended to affect both buying and selling prices, I would prefer to see two check-boxes. One to update buying prices automatically (which I would use) and one to update selling prices automatically (which I probably wouldn't use). That way, we don't need to have both if we only need one.

@Hafnianusha
Copy link

is it solved? i am also facing this issue

@impexbw
Copy link

impexbw commented Mar 4, 2024

same issue here how to fix?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants