Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Existing Price List Rate not working #40333

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Mar 7, 2024

The 'Update Existing Price List Rate' checkbox has enabled in the stock settings, but still after that the rate has not updated in the item price on changing of the rate in the sales order.

Fixed #35933

@mujeerhashmi
Copy link
Contributor

Needs backport to v14

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-update_existing_price_list_rate-11026 branch 2 times, most recently from 44995ef to a15ef1f Compare March 17, 2024 08:04
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-update_existing_price_list_rate-11026 branch from a15ef1f to cf59a69 Compare March 19, 2024 06:09
@JitendraSAW
Copy link

Any Update on the same when this will get fixed or merged

@rohitwaghchaure rohitwaghchaure merged commit 09ea7ed into frappe:develop Mar 19, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Mar 19, 2024
mergify bot pushed a commit that referenced this pull request Mar 19, 2024
(cherry picked from commit 09ea7ed)

# Conflicts:
#	erpnext/selling/doctype/sales_order/test_sales_order.py
#	erpnext/setup/demo_data/item.json
@JitendraSAW
Copy link

Can you tell me in which Release of Version 15 has come up

rohitwaghchaure added a commit that referenced this pull request Mar 19, 2024
…40527)

fix: Update Existing Price List Rate not working (#40333)

(cherry picked from commit 09ea7ed)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Mar 19, 2024
…40526)

* fix: Update Existing Price List Rate not working (#40333)

(cherry picked from commit 09ea7ed)

# Conflicts:
#	erpnext/selling/doctype/sales_order/test_sales_order.py
#	erpnext/setup/demo_data/item.json

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Mar 20, 2024
## [15.17.2](v15.17.1...v15.17.2) (2024-03-20)

### Bug Fixes

* achieved targets for sales partners ([1ac8887](1ac8887))
* advance journal fetching logic in Advances section ([bfa78aa](bfa78aa))
* attribute error on Bank Statement Import retry ([a0bf22c](a0bf22c))
* auto-update due date for invoices via data import ([9cdde50](9cdde50))
* balance qty in the stock ledger report (backport [#40506](#40506)) ([#40507](#40507)) ([69f442d](69f442d))
* currency symbol for Landed Cost Voucher Amount (backport [#40550](#40550)) ([#40554](#40554)) ([1c90797](1c90797))
* Data too long for column 'stock_queue' (backport [#40436](#40436)) ([#40451](#40451)) ([ba6b856](ba6b856))
* don't validate for currency, if account is unavailable ([5729ee5](5729ee5))
* flaky Accounts Receivable test case ([0bb4a7d](0bb4a7d))
* incorrect gross profit on the quotation (backport [#40438](#40438)) ([#40442](#40442)) ([ce2626e](ce2626e))
* index error on Exchange Rate Revaluation creation ([ebd967d](ebd967d))
* invalid exchange loss booking on invoice againts base accounts ([72c9cd5](72c9cd5))
* missing range for ageing summary ([dacc69c](dacc69c))
* not able to delete cancelled delivery note (backport [#40508](#40508)) ([#40510](#40510)) ([917a21b](917a21b))
* rate changing while making PR (negative discount) (backport [#40539](#40539)) ([#40540](#40540)) ([0bdda12](0bdda12))
* Remove custom queries for customer ([3133505](3133505))
* serial and batch for internal transfer (backport [#40467](#40467)) ([#40477](#40477)) ([61d59b3](61d59b3))
* show correct variance for durations with no vouchers ([bc78bc3](bc78bc3))
* stock reco negative batch (backport [#40533](#40533)) ([#40535](#40535)) ([7f1f780](7f1f780))
* stopped mr showing in the popup (backport [#40478](#40478)) ([#40480](#40480)) ([74b30a6](74b30a6))
* **Supplier Quotation Comparison:** group by options ([1e16d2c](1e16d2c))
* Taxes not getting updated on change ([75b610d](75b610d))
* **test:** manually filter rows and assert ([df13517](df13517))
* Update Existing Price List Rate not working (backport [#40333](#40333)) ([#40527](#40527)) ([44bbf4b](44bbf4b))
* use in_import flag for checking imported records ([8242a9c](8242a9c))
frappe-pr-bot pushed a commit that referenced this pull request Mar 20, 2024
## [14.65.4](v14.65.3...v14.65.4) (2024-03-20)

### Bug Fixes

* added index for voucher_detail_no in gl entry ([a1c8b93](a1c8b93))
* currency symbol for Landed Cost Voucher Amount (backport [#40550](#40550)) ([#40553](#40553)) ([7851311](7851311))
* Data too long for column 'stock_queue' ([#40450](#40450)) ([3340463](3340463))
* flaky ecommerce test case ([#40534](#40534)) ([b197c19](b197c19))
* get unique provisional accounts ([39d958c](39d958c))
* index error on Exchange Rate Revaluation creation ([8813b6b](8813b6b))
* invalid exchange loss booking on invoice againts base accounts ([a27f386](a27f386))
* missing range for ageing summary ([9f0ad7a](9f0ad7a))
* provisional entry for non-stock item ([0aef7f9](0aef7f9))
* **Supplier Quotation Comparison:** group by options ([cfed706](cfed706))
* Update Existing Price List Rate not working (backport [#40333](#40333)) ([#40526](#40526)) ([64f1844](64f1844))
* warehouse issue in pick list ([#40453](#40453)) ([5a2eaf9](5a2eaf9))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchase and Sales Rate not getting Updated.
3 participants