Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Item-wise Sales and Purchase register with no item codes #41373

Closed
1 task
deepeshgarg007 opened this issue May 8, 2024 · 0 comments
Closed
1 task

fix: Item-wise Sales and Purchase register with no item codes #41373

deepeshgarg007 opened this issue May 8, 2024 · 0 comments
Assignees
@Poorvi-R-Bhat
Labels
bug good first issue Good issue for beginners.

Comments

@deepeshgarg007
Copy link
Member

deepeshgarg007 commented May 8, 2024 •
edited
Loading

Information about bug

ERPNext allows creation of Sales/Purchase Invoices without having an item master (item code) for petty income/expense
Such invoices are pulled in Sales and Purchase register not in item-wise sales and purchase register which leads to mis-match in both these reports

A possible solution for this could be to do a left join on the Sales Invoice/Sales Invoice Item table

Other ToDos:

  • Rewrite all the raw SQL queries using query builder
@deepeshgarg007 deepeshgarg007 added the good first issue Good issue for beginners. label May 8, 2024
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 13, 2024
@Poorvi-R-Bhat
fix: Item-wise Sales and Purchase register with no item codes frappe#…
1b45ecf 
…41373
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 22, 2024
@Poorvi-R-Bhat
fix: fixing Item-wise sales register and purchase register frappe#41373
76073ae
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 22, 2024
@Poorvi-R-Bhat
fix: fixing Item-wise sales register frappe#41373
eafa88b
deepeshgarg007 added a commit that referenced this issue Jun 9, 2024
@deepeshgarg007
Merge pull request #41424 from Poorvi-R-Bhat/item-code-purchase-sales…
c9bcd70 
…-register

fix: Item-wise Sales and Purchase register with no item codes #41373
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: Item-wise Sales and Purchase register with no item codes #41373
96405e8 
(cherry picked from commit 1b45ecf)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register and purchase register #41373
a4b28ba 
(cherry picked from commit 76073ae)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register #41373
5e0fa1b 
(cherry picked from commit eafa88b)

# Conflicts:
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: Item-wise Sales and Purchase register with no item codes #41373
bc24e75 
(cherry picked from commit 1b45ecf)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register and purchase register #41373
ee47440 
(cherry picked from commit 76073ae)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
mergify bot pushed a commit that referenced this issue Jun 9, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register #41373
ab90b81 
(cherry picked from commit eafa88b)

# Conflicts:
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: Item-wise Sales and Purchase register with no item codes #41373
3e0123b 
(cherry picked from commit 1b45ecf)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
(cherry picked from commit 96405e8)
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register and purchase register #41373
50ef81a 
(cherry picked from commit 76073ae)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
(cherry picked from commit a4b28ba)
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register #41373
d75d64e 
(cherry picked from commit eafa88b)

# Conflicts:
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
(cherry picked from commit 5e0fa1b)
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: Item-wise Sales and Purchase register with no item codes #41373
91de469 
(cherry picked from commit 1b45ecf)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
(cherry picked from commit bc24e75)
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register and purchase register #41373
fd73a8a 
(cherry picked from commit 76073ae)

# Conflicts:
#	erpnext/accounts/report/item_wise_purchase_register/item_wise_purchase_register.py
(cherry picked from commit ee47440)
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@Poorvi-R-Bhat @mergify
fix: fixing Item-wise sales register #41373
e8286d7 
(cherry picked from commit eafa88b)

# Conflicts:
#	erpnext/accounts/report/item_wise_sales_register/item_wise_sales_register.py
(cherry picked from commit ab90b81)
frappe-pr-bot pushed a commit that referenced this issue Jun 10, 2024
@frappe-bot
chore(release): Bumped to Version 15.27.2
f2909e9 
## [15.27.2](v15.27.1...v15.27.2) (2024-06-10)

### Bug Fixes

* Add additional condition application ([45c16f6](45c16f6))
* fixing Item-wise sales register ([9a629f8](9a629f8))
* fixing Item-wise sales register [#41373](#41373) ([d75d64e](d75d64e))
* fixing Item-wise sales register and purchase register [#41373](#41373) ([50ef81a](50ef81a))
* Item-wise Sales and Purchase register with no item codes [#41373](#41373) ([3e0123b](3e0123b))
frappe-pr-bot pushed a commit that referenced this issue Jun 10, 2024
@frappe-bot
chore(release): Bumped to Version 14.70.5
0c4a2af 
## [14.70.5](v14.70.4...v14.70.5) (2024-06-10)

### Bug Fixes

* Add additional condition application ([810378c](810378c))
* fixing Item-wise sales register ([3823e0e](3823e0e))
* fixing Item-wise sales register [#41373](#41373) ([e8286d7](e8286d7))
* fixing Item-wise sales register and purchase register [#41373](#41373) ([fd73a8a](fd73a8a))
* Item-wise Sales and Purchase register with no item codes [#41373](#41373) ([91de469](91de469))
frappe-pr-bot pushed a commit that referenced this issue Jun 11, 2024
@frappe-bot
chore(release): Bumped to Version 14.70.6
32fba94 
## [14.70.6](v14.70.5...v14.70.6) (2024-06-11)

### Bug Fixes

* Add additional condition application ([e79e9e9](e79e9e9))
* fixing Item-wise sales register ([5d97c7c](5d97c7c))
* fixing Item-wise sales register [#41373](#41373) ([ab90b81](ab90b81))
* fixing Item-wise sales register and purchase register [#41373](#41373) ([ee47440](ee47440))
* Item-wise Sales and Purchase register with no item codes [#41373](#41373) ([bc24e75](bc24e75))
* terms and conditions for material request (backport [#41834](#41834)) ([#41836](#41836)) ([7234625](7234625))
frappe-pr-bot pushed a commit that referenced this issue Jun 11, 2024
@frappe-bot
chore(release): Bumped to Version 15.27.4
4d2d38c 
## [15.27.4](v15.27.3...v15.27.4) (2024-06-11)

### Bug Fixes

* Add additional condition application ([1fca6ea](1fca6ea))
* Add posting date to key for consolidated view ([9472085](9472085))
* Add timestamp to key for immutable views ([9e9bc8b](9e9bc8b))
* asset depreciations and balances report correction (backport [#41824](#41824)) ([#41851](#41851)) ([28b7fad](28b7fad))
* calculate totals and taxes ([5544309](5544309))
* Do no apply pricing rule on qty change for mapped docs ([822bc58](822bc58))
* do not fetch items with no active BOM in PP (backport [#41833](#41833)) ([#41835](#41835)) ([30c0b2b](30c0b2b))
* enable no_copy for timesheet in sales invoice ([f1ad0f6](f1ad0f6))
* fixing Item-wise sales register ([f36db7e](f36db7e))
* fixing Item-wise sales register [#41373](#41373) ([5e0fa1b](5e0fa1b))
* fixing Item-wise sales register and purchase register [#41373](#41373) ([a4b28ba](a4b28ba))
* Item-wise Sales and Purchase register with no item codes [#41373](#41373) ([96405e8](96405e8))
* stock_value_change for legacy serial nos (backport [#41825](#41825)) ([#41826](#41826)) ([a7971cf](a7971cf))
* terms and conditions for material request (backport [#41834](#41834)) ([#41837](#41837)) ([1ead667](1ead667))
* typo in method - holiday list (backport [#41811](#41811)) ([#41812](#41812)) ([4d3e883](4d3e883))
* valuation rate for backdated legacy serial/batches (backport [#41788](#41788)) ([#41821](#41821)) ([8d31243](8d31243))
* valuation rate for serial and batch bundle for current bundle (backport [#41850](#41850)) ([#41860](#41860)) ([3e4c568](3e4c568))
* **Vehicle:** allow doc renaming and add test (backport [#41729](#41729)) ([#41785](#41785)) ([4d37739](4d37739))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Poorvi-R-Bhat Poorvi-R-Bhat

Labels
bug good first issue Good issue for beginners.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Poorvi-R-Bhat @deepeshgarg007