New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Route optimization for Delivery Trip stops #15566
Merged
rmehta
merged 7 commits into
frappe:staging-fixes
from
Alchez:feature-route-optimization
Nov 8, 2018
Merged
[Feature] Route optimization for Delivery Trip stops #15566
rmehta
merged 7 commits into
frappe:staging-fixes
from
Alchez:feature-route-optimization
Nov 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sagarvora, oh hey, just saw this. I'll check out the PR - thanks for the update. |
Looks good, but needs tests! https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#test-cases |
rmehta
reviewed
Oct 5, 2018
Alchez
force-pushed
the
feature-route-optimization
branch
2 times, most recently
from
October 12, 2018 07:55
7e80c67
to
bc12799
Compare
Alchez
force-pushed
the
feature-route-optimization
branch
2 times, most recently
from
October 19, 2018 13:29
f646f1b
to
f10df6c
Compare
codingCoffee
force-pushed
the
staging-fixes
branch
from
October 25, 2018 11:05
c17a647
to
9750d5c
Compare
Travis is failing. |
* Process and optimize the entire route, with or without locks * Form sets of routes for optimization based on applied lock positions * Re-arrange stops based on the optimized routes and lock positions * Set delay times between stops - offset estimation times by delays cumulatively
Alchez
force-pushed
the
feature-route-optimization
branch
from
November 6, 2018 09:40
f10df6c
to
013875e
Compare
@nabinhait, I've fixed the tests. Although Travis is now failing at trying to migrate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #15390.
This PR introduces provisions for Delivery Trip route optimization as described in general vehicle-routing and travelling salesman problems, and the implementation is based on Google's Directions API.
Features:
Screenshots / GIFs
Without position locks:
With position locks:
Global Defaults