Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add estimated distances to Delivery Trip #81

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Add estimated distances to Delivery Trip #81

merged 1 commit into from
Oct 15, 2018

Conversation

Alchez
Copy link

@Alchez Alchez commented Oct 10, 2018 •
edited

Added to existing PR upstream: frappe#15566

  • Google Maps returns distance values in meters, so we pick that up, convert it into the system-default distance UOM, and store it in both the Delivery Trip and the Delivery Stop documents.
  • The destination's latitude and longitude are also stored in hidden fields inside the Delivery Stop document.

Global Defaults

image

Parent doc

image

Child doc

image

@Alchez Alchez force-pushed the hotfix-trip-mileage branch 3 times, most recently from 91b646c to 7865b2d Compare October 12, 2018 07:42
@Alchez Alchez changed the title Add distance calculations to Delivery Trip Add estimated distances to Delivery Trip Oct 12, 2018
vjFaLk
vjFaLk suggested changes Oct 15, 2018
View reviewed changes
erpnext/setup/doctype/global_defaults/global_defaults.json Outdated
"allow_on_submit": 0,
"bold": 0,
"collapsible": 0,
"columns": 0,
"default": "Kilometer",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're setting a default here then we need to write a patch to do the same for existing sites.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from a previous test. I've removed it now.

erpnext/stock/doctype/delivery_stop/delivery_stop.json Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 15, 2018

There were the following issues with this Pull Request

  • Commit: f11679f7529a32d5ee21a316a159c49010f715d2
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@Alchez Alchez merged commit d4a51bd into Bloomstack:bloomstack-staging Oct 15, 2018
@Alchez Alchez deleted the hotfix-trip-mileage branch February 8, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjFaLk vjFaLk vjFaLk approved these changes

@neilLasrado neilLasrado Awaiting requested review from neilLasrado

Assignees

@vjFaLk vjFaLk

@neilLasrado neilLasrado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alchez @vjFaLk @neilLasrado