Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Currency Exchange for_selling and for_buying on the same day #19339

Merged
merged 12 commits into from
Nov 11, 2019
Merged

fix: Currency Exchange for_selling and for_buying on the same day #19339

merged 12 commits into from
Nov 11, 2019

Conversation

toofun666
Copy link
Contributor

Please read the pull request checklist to make sure your changes are merged: https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist

In this fix:

  • You can now add a separate exchange_rate in date for_selling and for_buying. You could not before because the unique field name was only calculated to allow a single name for a date
  • tests did not account for for_selling and for_buying fields and thier uniqueness

test data of Currency Exchange to incluse buying and selling
…xchange_rate

Currency Exchange Test corrected to include selling and buying exchange_rate
…ctionality restored


In this fix:
* You can now add a separate exchange_rate in date for_selling and for_buying. You could not before because the unique field name was only calculated to allow a single name for a date
* tests did not account for for_selling and for_buying fields and thier uniqueness
@toofun666
Copy link
Contributor Author

Dears,
this update will help the vanilla systems to function better in Currency Exchange. The test has also been updated to cover the full scenario where for_selling and for_buying are required fields but were not covered in the test.

…ions specific to Turkey will be created under that package.
updated the code regarding spaces issue
@toofun666
Copy link
Contributor Author

Let us get this going to put the design back into place with proper testing on Currency Exchange.
The problem was:

  • for_selling or for_buying was a must
  • the naming was based on parameters excluding these fields
  • thus you could not enter a buying and selling currency exchange rate for the same day because of unique naming construction

@nabinhait nabinhait merged commit 06c6f7c into frappe:develop Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants