fix(loyalty): loyalty point entry use wrong tier

[pipech]

Fix for > [Bug] V12 - Loyalty program: Loyalty Point Entry use wrong Tier #22167

This is incorrect because it loop from highest and see if cumulative amount is less than min tier spend but it won't work if min tier spend is at 0 (Which it can be since min tier spend is not mandatory field)
that might be why he add i == 0 to skip this error.

The new method loop from lowest and check if cumulative spend is more than min spend.

[olamide2]

Thank you. I have been complaining about this for months

[rohitwaghchaure]

@pipech Kindly send this PR on develop branch too

[marination]

@pipech Travis seems to be failing, please fix tests in test_loyalty_program.py

[pipech]

I will but it will take time for me to setup testing properly.

I've tried to run it but in some version it will error on Running "before_test" or it will take too long just to run "before_test", I haven't got to unittest part.

Do you guys have any recommendation on setting up testing environment ?

But from initial look on unittest, I think the problem is customer doctype haven't got reload after create sales invoice so loyalty_program_tier will be none.

[hoangdinhanphabe]

This issue still persists on v13 Beta 10