-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: shift management #22262
refactor: shift management #22262
Conversation
9740abc
to
b26540f
Compare
b26540f
to
de12368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this line to reflect the changes in Shift Assignment:
filters = {'date':('>=', from_date), 'shift_type': self.name, 'docstatus': '1'} |
af53eeb
to
5e4243c
Compare
34d88a9
to
8a1b348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto Attendance related changes LGTM.
yeah tested it with Marica |
Patch for Shift Assignment |
a6d7133
to
b0c3f40
Compare
Co-authored-by: Marica <maricadsouza221197@gmail.com>
b0c3f40
to
f096ba4
Compare
@marination please check. |
Shift Assignment:
Previously user needs to assign shift daily.
There should be an active shift for a period if there is an end date else it is an ongoing shift.
Shift Request:
New approval system and approver for Shift Request. on approval shift assignment is created automatically.
Employee:
New section Approvers With New Field Shift request Approver. Set Employee Wise Shift request Approver.
Department:
New child Table Shift request Approver to set Department wise shift Approver.
Docs
frappe/erpnext_documentation#123