Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: handle exceptions when updating addresses #22307

Merged
merged 2 commits into from Jun 18, 2020
Merged

refactor: handle exceptions when updating addresses #22307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538d9c8
refactor: handle exceptions when updating addresses
scmmishra Jun 18, 2020
760a903
refactor: fold common statements in a loop
scmmishra Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 19 additions & 4 deletions erpnext/erpnext_integrations/connectors/woocommerce_connection.py
View file
Open in desktop
Expand Up @@ -73,10 +73,25 @@ def link_customer_and_address(raw_billing_data, raw_shipping_data, customer_name

if customer_exists:
frappe.rename_doc("Customer", old_name, customer_name)
billing_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Billing"})
shipping_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Shipping"})
rename_address(billing_address, customer)
rename_address(shipping_address, customer)
try:
billing_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Billing"})
rename_address(billing_address, customer)
except (
frappe.DoesNotExistError,
frappe.DuplicateEntryError,
frappe.ValidationError,
):
pass

try:
shipping_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Shipping"})
rename_address(shipping_address, customer)
except (
frappe.DoesNotExistError,
frappe.DuplicateEntryError,
frappe.ValidationError,
):
pass
scmmishra marked this conversation as resolved.
Show resolved Hide resolved
else:
create_address(raw_billing_data, customer, "Billing")
create_address(raw_shipping_data, customer, "Shipping")
Expand Down