refactor: handle exceptions when updating addresses #22307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
requested review from
Mangesh-Khairnar and
nextchamp-saqib
as code owners
|
@Mergifyio backport version-12-hotfix |
|
Command
|
marination
reviewed
Jun 18, 2020
erpnext/erpnext_integrations/connectors/woocommerce_connection.py
Outdated
Show resolved
Hide resolved
marination
approved these changes
Jun 18, 2020
|
@Mergifyio backport v12-pre-release |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2020
* refactor: handle exceptions when updating addresses * refactor: fold common statements in a loop (cherry picked from commit 34d2bfb)
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2020
* refactor: handle exceptions when updating addresses * refactor: fold common statements in a loop (cherry picked from commit 34d2bfb)
|
Command
|
nabinhait
pushed a commit
that referenced
this pull request
Jun 18, 2020
nabinhait
pushed a commit
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a customer, it maybe the case that one of the addresses may not be present. This PR manages those conditions