Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generic Message in previous doc validation for buying and selling #22546

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

marination
Copy link
Collaborator

@marination marination commented Jul 1, 2020

Issue:
_ToJofWa

Make message to Validate Previous Document generic for Sales and Purchase
Sales
Screenshot 2020-07-01 at 9 31 42 PM

Purchase
Screenshot 2020-07-01 at 9 33 05 PM

@marination
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@marination marination changed the title fix: General Message in previous doc validation for buying and selling fix: Generic Message in previous doc validation for buying and selling Jul 1, 2020
Copy link
Contributor

@Anurag810 Anurag810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis Failing: Need to set precision in test.

@Anurag810 Anurag810 self-assigned this Jul 3, 2020
@Anurag810 Anurag810 merged commit 5f299a0 into frappe:develop Jul 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed

Cherry-pick of 5f299a0 has failed:

On branch mergify/bp/version-12-hotfix/pr-22546
Your branch is up to date with 'origin/version-12-hotfix'.

You are currently cherry-picking commit 5f299a08bd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   erpnext/utilities/transaction_base.py

no changes added to commit (use "git add" and/or "git commit -a")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants