Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Leave application status fix #23043

Merged
merged 3 commits into from
Aug 18, 2020
Merged

fix: Leave application status fix #23043

merged 3 commits into from
Aug 18, 2020

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Aug 14, 2020 •
edited
Loading

Issue - After canceling the leave the status is not updated.
image

Fix -
Making Enable Allow On Submit on Status field.
image

Anurag810
Anurag810 suggested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@Anurag810 Anurag810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write a patch for old data having docstatus = 2 and status = 'Aprroved' and set status = Cancelled.

@Anurag810 Anurag810 merged commit 09b6628 into frappe:version-12-hotfix Aug 18, 2020
This was referenced Sep 22, 2020
Merged
Merged
@nabinhait nabinhait mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anurag810 Anurag810 Anurag810 approved these changes

@nabinhait nabinhait Awaiting requested review from nabinhait

Assignees

@Anurag810 Anurag810

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anupamvs @Anurag810