Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot merge pos invoices with inclusive tax #23541

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix: cannot merge pos invoices with inclusive tax #23541

merged 2 commits into from
Oct 8, 2020

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Oct 7, 2020 •
edited
Loading

Problem:

  • Merging into sales invoice converts all type of taxes to Actual
  • If POS Invoice has item with inclusive tax then submitting of sales invoice with actual inclusive tax throws error

Fix:

  • Recalculate item rate to based on POS Invoice Item net rate
  • Recalculated rate will be used to calculate tax again to adjust and give proper grand total
  • For eg. If Item 1 in POS Invoice has tax inclusive rate of 300Rs with 10% tax i.e 30Rs. Then while merging into Sales Invoice, the rate will be set as 270Rs with 30Rs actual tax amount.

@nextchamp-saqib nextchamp-saqib merged commit 22b4c86 into frappe:develop Oct 8, 2020
@rohitwaghchaure rohitwaghchaure mentioned this pull request Nov 5, 2020
Merged
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nextchamp-saqib