Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Education Module fixes #23714

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

ruchamahabal
Copy link
Member

  • Added filters for Course (according to program) and Academy Term (according to the academic year)

    academic-term

    course-filter

    Similar filters added in Assessment Plan and Assessment Result.

  • Validation for attendance marked for future dates in Student Attendance and Student Attendance Tool

    attendance-future-dates

    attendance-tool

  • Validation for Attendance marked outside of Academic Year dates

    attendance_outside_academic_year

@ruchamahabal ruchamahabal changed the title fix: Education module fixes fix: Education Module fixes Oct 23, 2020
@ruchamahabal ruchamahabal merged commit e977bc3 into frappe:develop Oct 23, 2020
@fderyckel
Copy link
Contributor

Hey @ruchamahabal,
I think the rows in instructor log should be fetched automatically.
Once an instructor has been scheduled for a course (or has been assigned to a student group), then it will be added to the instructor log type.
This is the same model as on the guardian doctype where children are automatically added to the guardian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants