feat: Putaway #23969
Merged
feat: Putaway #23969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added UOM & conversion factor field in Putaway Rule - Items are split and assigned as per UOM - Handled Whole UOMs too
- Fixed Sider Issues - Added perms to Putaway Rule - Added Unit Tests to check warehouse assignment
1 task
marination
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
- Validate capacity < stock level only on new rule - Mention stock uom while validating capacity in new rule - Separate function to format and display unassigned items - Format ORM args
- Added Page Warehouse Capacity Summary - Added Page to Desk and Putaway List View - Reused Item Dashboard/Stock Balance page render code - Added naming series to Putaway Rule
- Added checkbox 'Apply Putaway Rule' in PR and SE - Added link to rule in child tables - Rule is applied on Save - Validation for over receipt - Apply Rule on Stock Entry as well for Material Transfer and Receipt
- Table is reset and overwritten with applied rules on checkbox trigger - Sider fixes
- Tests as per new design flow - Fixed duplicate data bug in Warehouse Capacity Summary - Set Amount currently on applying rule in client side - Apply rules on server side before validate
- Maintain item-warehouse wise rules for Stock Entry Material Transfer - Test cases for Stock Entry with more use cases - Sider fixes
- Fix incorrect indentation after merge conflict - Sider
- Validation for overreceipt on Purchase Invoice, Stock Entry, Purchase Receipt & Stock Reconciliation - Every incoming stock transaction must be checked to avoid overcapacity - However application of rule and splitting only on certain doctypes - Validate capacity < stock balance on save in putaway rule, irrespective
rohitwaghchaure
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation: frappe/erpnext_documentation#203
Depends on frappe/frappe#11976
Putaway Rule
You can create a Putaway Rule that will specify what Item this rule is applicable on. It will also specify the capacity in a Warehouse for this Item. You can set a priority to determine which rule should be applicable first.
This rule basically says Item Rice (kg) can be held in Warehouse Zone 2: Rack 2 - HUL which has a maximum capacity of 5000 kg for this Item.
Working
The Putaway Rules are applied on Purchase Receipts and Stock Entries (only of type Material Receipt and Material Transfer)
They are applied on the save of a Purchase Receipt/Stock Entry and also on enabling Apply Putaway Rule checkbox
If all the Rules are exhausted and the Warehouses are at capacity, feedback is given.
Warehouse Capacity Summary
You can also see how much of your warehouses are occupied and can change the Capacity too via Warehouse Capacity Summary.
ToDo:
Improve feedback formatting for unallocated Items
Add UOM in Rule and Update as per UOM
Tests (Update tests with more use cases)
Documentation(update docs with new design)
Create a Capacity vs Current Stock Level Summary
Change Rule Application Design(apply on save in form) and Block Over Receipt via Applied Rule
Apply Rule on checkbox trigger