fix: Added TDS Payable account number and an error message #24065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuja-pawar
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
marination
reviewed
Dec 5, 2020
erpnext/accounts/utils.py
Outdated
| @@ -78,7 +78,10 @@ def get_fiscal_years(transaction_date=None, fiscal_year=None, label="Date", verb | |||
| else: | |||
| return ((fy.name, fy.year_start_date, fy.year_end_date),) | |||
|
|
|||
| error_msg = _("""{0} {1} not in any active Fiscal Year.""").format(label, formatdate(transaction_date)) | |||
| error_msg = _("""{0} {1} not in any active Fiscal Year""").format(label, formatdate(transaction_date)) | |||
There was a problem hiding this comment.
why is this in the for loop
…any_fiscal_year_fix Merge branch 'develop' of https://github.com/frappe/erpnext into company_fiscal_year_fix
marination
reviewed
Dec 7, 2020
marination
reviewed
Dec 7, 2020
…any_fiscal_year_fix Merge branch 'develop' of https://github.com/frappe/erpnext into company_fiscal_year_fix
…war/erpnext into company_fiscal_year_fix
marination
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the customers reported this issue they faced while creating a new company with the Chart of Accounts template standard with numbers.
It was thrown because TDS Payable had no account number assigned in the standard template with numbers.
So, we added the TDS Payable account number in a template Standard Chart of Accounts with numbers.
Also, on digging into it further, we found out this error message which appears when you don't have any active fiscal year for that specific company (or a fiscal year with no company), so we updated that error message to make it more precise.
Before:
After:
