New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bank Reconciliation): Redesign #24273
feat(Bank Reconciliation): Redesign #24273
Conversation
0b63510
to
83146c4
Compare
Correct me if I am wrong, but this appears to be primarily a user-interface redesign. Is there any chance of incorporating improvements to the underlying significant issue with bank reconciliation as addressed in #23721 that I filed three months ago? The basic problem is illustrated by a transfer between two different bank accounts. Such a transfer shows up in the statements from both accounts. If you reconcile the Bank Transaction from the first account against the (single) Journal Entry for the transfer, then there is no way to reconcile the Bank Transaction from the second account, since the matching Journal Entry is already "used up". The core difficulty is that a single Journal Entry can represent multiple actions against different Bank Accounts. That's why a Bank Transaction has to be reconciled against a single Journal Entry Account row, not against an entire Journal Entry. I would be happy to work on top of this branch and incorporate the sort of changes from #23721 if it would help get this very important improvement into ERPNext more quickly. Please just let me know how I can lend my effort to getting this improved. Much obliged. |
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
Show resolved
Hide resolved
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
Show resolved
Hide resolved
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
Outdated
Show resolved
Hide resolved
This comment was marked as abuse.
This comment was marked as abuse.
b5fbd93
to
b088999
Compare
This is not assumed you can either create a document and then match or create it directly
This new tool makes the Bank reconciliation process faster with no routes. In the approach, you are suggesting it is necessary to go to each bank transaction and match it with a voucher. This is not at all an upgrade over just updating the clearance dates
|
5686238
to
df426af
Compare
79cd128
to
42a0db3
Compare
…ain2808/erpnext into Bank-Reconciliation-Doctype
This comment was marked as abuse.
This comment was marked as abuse.
Hi @casesolved-co-uk ,
I do not think it breaks that idea. You can add and match any transaction from the tool. If in your use case you do not want to use the balance mismatch functionality ignore the balances. You can put any value in the closing balance field. I think we can make the closing balance field non-mandatory so it is not necessary to add any value.
The new tool is better in terms of usability. Manually syncing the plaid transactions is available in Bank Reconciliation is a more generic tool and can be used for Bank Transactions from any source.
The new tool does not remove any of the existing functionalities rather adds many more. We had done an extensive survey of the issues being faced by the users in the old tool and then tried solving as many as possible. Most of the changes were UI/UX. Please do tell which use cases were available in the older tool but are not available in the new tool. |
This comment was marked as abuse.
This comment was marked as abuse.
The blog does not include everything that was done in the redesign. The blog includes only some parts. This is mentioned at the end of the blog. We redesigned the bank reconciliation tool and the bank statement import. Plaid integration was not redesigned hence no mention of it Moreover we did make sure that the redesign does not break the integration and it is working perfectly fine. Tested it multiple times. You can add the plaid credentials in plaid settings. You can link new accounts and sync transactions by using the buttons. The only thing that didn't work was that the tool didn't show the transactions without putting a non zero value in closing balance because depends-on is considering 0 as a falsy value. For this issue I have already given a workaround to put any value. The fix for it is also raised which would make sure it works with zero/ null values too. If there are still use cases in your mind that are not available in the redesign please do tell. |
Redesign of Bank Reconciliation
Bank Statement Import
Bank Reconciliation Tool
Matching Vouchers
Creating New Voucher
Updating Bank Transaction
Docs Link: frappe/erpnext_documentation#230