Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create Journal Entry from Bank Transaction, requires frappe bugfix - V13 #24493

Closed
wants to merge 2 commits into from
Closed

feat: Create Journal Entry from Bank Transaction, requires frappe bugfix - V13 #24493

wants to merge 2 commits into from

Conversation

nameduser0
Copy link
Contributor

V13 port of #24492

@hasnain2808
Copy link
Contributor

Please Check #24273
Creating Journal Entry from Bank Transaction

@nameduser0

This comment was marked as abuse.

Sign in to view
@hasnain2808
Copy link
Contributor

Please Check #24273

I've left a review. I think you need to consider other use-cases for your code.
For example, automatic bank reconciliation via Plaid and creation of missing JE's based on previously manually created vouchers, reconciled against matching bank transactions. Also JE creation with manual intervention.

All of these were considered and possible

@nameduser0 nameduser0 changed the title feat: Create Journal Entry from Bank Transaction, requires frappe bugfix V13 feat: Create Journal Entry from Bank Transaction, requires frappe bugfix Feb 2, 2021
@nameduser0 nameduser0 changed the title V13 feat: Create Journal Entry from Bank Transaction, requires frappe bugfix feat: Create Journal Entry from Bank Transaction, requires frappe bugfix - V13 Feb 3, 2021
@nameduser0 nameduser0 marked this pull request as draft February 13, 2021 17:14
@nameduser0

This comment was marked as abuse.

Sign in to view
@nabinhait nabinhait changed the base branch from develop to version-13-hotfix May 3, 2021 17:32
@stale
Copy link

stale bot commented Jul 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 20, 2021
@stale stale bot closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar will be requested when the pull request is marked ready for review ruthra-kumar is a code owner

Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nameduser0 @hasnain2808 @casesolved-co-uk