Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serial no refresh issue #25127

Merged
merged 2 commits into from
Apr 8, 2021
Merged

fix: serial no refresh issue #25127

merged 2 commits into from
Apr 8, 2021

Conversation

pateljannat
Copy link
Contributor

@pateljannat pateljannat commented Apr 1, 2021 •
edited
Loading

Issue:

  1. While scanning serial numbers in transaction documents like Purchase Receipt, some serial numbers used to disappear.
  2. This was happening because the call chain that triggers after entering the serial number wasn't as fast as the next input entry.

Purcahse receipt scanning

Fix:

  1. The call chain has been throttled so that it doesn't trigger after every serial number entered.

@pateljannat pateljannat mentioned this pull request Apr 1, 2021
Merged
@pateljannat pateljannat mentioned this pull request Apr 1, 2021
Merged
@ruchamahabal ruchamahabal merged commit d9fa79d into frappe:develop Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

@marination marination Awaiting requested review from marination

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @ruchamahabal