Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task status loop #26006

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Conversation

pateljannat
Copy link
Contributor

Issue:

if flt(self.progress) == 100:
	self.status = 'Completed'

if self.status == 'Completed':
	self.progress = 100

The above code snippet was causing a loop in Task doctype.

Steps to Replicate:

  1. Create a task.
  2. Mark it as Complete. Save
  3. Change the status to Open. Save.
  4. The status should remain as Open on save.

@ruchamahabal
Copy link
Member

@pateljannat backport this version-13-hotfix too

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 42.968% when pulling d3eef94 on pateljannat:task-status-loop into c978fdf on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@ruchamahabal
Copy link
Member

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Feb 16, 2022
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit ccb52f1)
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

backport version-13-hotfix

✅ Backports have been created

ruchamahabal added a commit that referenced this pull request Feb 16, 2022
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants