Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add timeout to GHA workflows #26714

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 29, 2021

If a workflow is stuck for whatever reason, it won't stop until the default limit of 6 hours is hit, wasting resources.

Limited most workflows to a maximum of 60 minutes. (which is 2-3x our current max running time)

@ankush ankush merged commit 0bb60b3 into frappe:develop Jul 29, 2021
@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport/version-13-hotfix/26714 origin/version-13-hotfix
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0bb60b37df4517c81cf684042bc8d42ea2a67364
# Push it to GitHub
git push --set-upstream origin backport/version-13-hotfix/26714
git switch main
# Remove the local backport branch
git branch -D backport/version-13-hotfix/26714

Then, create a pull request where the base branch is version-13-hotfix and the compare/head branch is backport/version-13-hotfix/26714.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
Copy link
Member Author

ankush commented Dec 1, 2021

@Mergifyio backport version-13-hotfix

@ankush ankush deleted the timeout_workflow branch December 1, 2021 05:51
mergify bot pushed a commit that referenced this pull request Dec 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2021

backport version-13-hotfix

✅ Backports have been created

@ankush
Copy link
Member Author

ankush commented Dec 1, 2021

@Mergifyio backport version-13-pre-release

ankush added a commit that referenced this pull request Dec 1, 2021
(cherry picked from commit 0bb60b3)

Co-authored-by: Ankush <ankush@iwebnotes.com>
mergify bot pushed a commit that referenced this pull request Dec 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2021

backport version-13-pre-release

✅ Backports have been created

ankush added a commit that referenced this pull request Dec 1, 2021
(cherry picked from commit 0bb60b3)

Co-authored-by: Ankush <ankush@iwebnotes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants