Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pos invoice coupon code feature #27004

Merged

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Aug 18, 2021

Description:

  • This feature allows you to apply a coupon code created through the existing Coupon Code doctype at the POS checkout screen.
  • Lets you type in the coupon code and a dropdown of relevant coupons will pop up.

Steps:

  1. Create a pricing rule for 'Selling' such as the following:

Screenshot 2021-08-27 at 3 27 30 PM

Screenshot 2021-08-27 at 3 28 05 PM

**If the 'Apply On' field has item group selected, add a subsequent item group in the table, same for other options too. The discount will be applicable only for those items which come under the applied option, here its Item Group - POS test items, so items with POS test items as their 'Item Group' only will have this applied.**
  1. Create a Coupon Code

Screenshot 2021-08-27 at 3 28 05 PM

  1. Select the created coupon code at the POS screen

no-docs

erpnext/accounts/doctype/pricing_rule/pricing_rule.py Outdated Show resolved Hide resolved
erpnext/accounts/doctype/pricing_rule/pricing_rule.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 24, 2021

Coverage Status

Coverage increased (+0.05%) to 51.38% when pulling a9c6086 on nemesis189:pos-invoice-coupon-code-feature into 9e82c24 on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit d4d5a42 into frappe:develop Aug 24, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 24, 2021
@sagarvora
Copy link
Collaborator

Why hasn't the modified timestamp been updated? Did you modify pos_invoice.json directly?

@nemesis189
Copy link
Contributor Author

Why hasn't the modified timestamp been updated? Did you modify pos_invoice.json directly?

No, I didn't touch the json file

@nextchamp-saqib
Copy link
Member

Why hasn't the modified timestamp been updated? Did you modify pos_invoice.json directly?

I gues due to this 086053d, while resolving conflicts, modified timestamp is the latest one though. Will it cause a problem? @sagarvora

@sagarvora
Copy link
Collaborator

@nextchamp-saqib Yes, this will cause an issue. The DocType only gets synced with ERP if the modified timestamp is newer (not same or older).

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants