Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot create task with *Apply Strict User Permissions* #27214

Closed
wants to merge 13 commits into from
Closed

fix: cannot create task with *Apply Strict User Permissions* #27214

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e7fd222
fix: cannot create task with *Apply Strict User Permissions*
ahmadpak Aug 28, 2021
bbb997c
ci: use node action instead of apt (#27220)
ankush Aug 30, 2021
159ab6f
feat(Healthcare): Capacity for Service Unit, concurrent appointments …
ruchamahabal Aug 30, 2021
7194c0f
fix: expense claim reimbursed amount update (#27204)
nemesis189 Aug 30, 2021
44eda22
feat: (consistency) Add Primary Address and Contact section in Supplier
marination Aug 27, 2021
770cdc2
fix: Popup stale build and data consistency
marination Aug 27, 2021
489574d
fix: Indentation and removed f-strings
marination Aug 30, 2021
f9a7691
ci: concurrency control for CI jobs (#27230)
ankush Aug 30, 2021
fc5c1e1
fix: Correct company address not getting copied from Purchase Order t…
deepeshgarg007 Aug 30, 2021
ce1f142
fix: Stock Ageing report issues for serialized items (#27228)
rtdany10 Aug 30, 2021
37ba4bb
refactor: Healthcare Redesign Changes (#27236)
ruchamahabal Aug 30, 2021
df27595
refactor(task): import declared in the begining
ahmadpak Aug 30, 2021
f6cad39
Merge branch 'develop' into fix-task-permission
ahmadpak Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion erpnext/projects/doctype/task/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from frappe.model.mapper import get_mapped_doc
from frappe.utils import add_days, cstr, date_diff, get_link_to_form, getdate, today, flt
from frappe.utils.nestedset import NestedSet

from frappe.defaults import get_user_default

class CircularReferenceError(frappe.ValidationError): pass
class EndDateCannotBeGreaterThanProjectEndDateError(frappe.ValidationError): pass
Expand Down Expand Up @@ -318,6 +318,13 @@ def add_node():

if args.parent_task == 'All Tasks' or args.parent_task == args.project:
args.parent_task = None
if args.parent_task == args.project:
args.company == frappe.get_value('Project', args.project, 'company')
else:
args.company == get_user_default('company')

else:
args.company = frappe.get_value('Task', args.parent_task, 'company')

frappe.get_doc(args).insert()

Expand All @@ -326,6 +333,7 @@ def add_multiple_tasks(data, parent):
data = json.loads(data)
new_doc = {'doctype': 'Task', 'parent_task': parent if parent!="All Tasks" else ""}
new_doc['project'] = frappe.db.get_value('Task', {"name": parent}, 'project') or ""
new_doc['company'] = frappe.db.get_value('Task', {"name": parent}, 'company') or get_user_default('company')

for d in data:
if not d.get("subject"): continue
Expand Down