fix: TaxJar update - added nexus list, making api call only for nexus #27497

nemesis189 · 2021-09-14T15:18:41Z

Update:

Added a child table to display nexus and retrieve data from it when required
API calls to retrieve tax from the taxjar api will be made only for nexus states
Button to update Nexus list in the TaxJar Settings page
sales_tax attribute attached in the API payload before creating the transaction

erpnext/erpnext_integrations/taxjar_integration.py

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.js

erpnext/erpnext_integrations/taxjar_integration.py

erpnext/erpnext_integrations/doctype/taxjar_nexus_list/taxjar_nexus_list.json

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

…ttings.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

…ttings.js Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py

… sandbox mode checks

erpnext/patches/v13_0/custom_fields_for_taxjar_integration.py

Alchez · 2021-10-11T05:45:12Z

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py

+		TAXJAR_CREATE_TRANSACTIONS = frappe.db.get_single_value("TaxJar Settings", "taxjar_create_transactions")
+		TAXJAR_CALCULATE_TAX = frappe.db.get_single_value("TaxJar Settings", "taxjar_calculate_tax")
+		TAXJAR_SANDBOX_MODE = frappe.db.get_single_value("TaxJar Settings", "is_sandbox")


I'm not sure if you need the db calls here, since you already have the context of the TaxJar Settings document

deepeshgarg007 · 2021-10-13T09:38:10Z

@Mergifyio backport version-13-hotfix

mergify · 2021-10-13T09:38:19Z

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

mergify · 2021-10-13T09:39:32Z

Command backport version-13-hotfix: success

Backports have been created

#27940 fix: TaxJar update - added nexus list, making api call only for nexus (backport #27497) has been created for branch version-13-hotfix

… (backport #27497) (#27940) * fix: TaxJar update - nexus, selective api call (cherry picked from commit b01fe1c) * fix: sales_tax attribute in api call before submit (cherry picked from commit 3bb60a4) * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 0e52731) * Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 486d7c3) * Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.js Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 435a5e4) * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 11bd424) * fix: Renamed child table doctype, delete taxes for non nexus state (cherry picked from commit 5c18654) * fix: updated patch, add fields only if fields are checked (cherry picked from commit 54754f4) # Conflicts: # erpnext/patches/v13_0/custom_fields_for_taxjar_integration.py * fix: patch fix, fields disabling (cherry picked from commit 0a28fed) * fix: using db.exists and get_value instead of get_doc (cherry picked from commit 8675ca5) * fix: dt instead of document in set_value query (cherry picked from commit d3bb920) * minor fixes (cherry picked from commit 254b20b) * fix: improved on_update method, added validation for tax calculation, sandbox mode checks (cherry picked from commit 7114659) * fix: linters fix (cherry picked from commit 3ece05a) * fix: patch fix added reload_doctype (cherry picked from commit eaa3614) * fix: patch fixes- force reload doc, check for company (cherry picked from commit 1b25e69) * fix: 'Taxjar' type fix (cherry picked from commit ea20384) * fix: Update pacthes.txt (cherry picked from commit 5d4c919) * fix: Patch (cherry picked from commit 2d19e2d) # Conflicts: # erpnext/patches.txt * fix: Move product tax category folder to taxjar settings (cherry picked from commit bd8cfb2) * Update custom_fields_for_taxjar_integration.py * fix: conflicts * fix: linter issues removed extra line * fix: patch fix einvoicing deprecation patch removed Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>

fix: TaxJar update - added nexus list, making api call only for nexus

… (backport frappe#27497) (frappe#27940) * fix: TaxJar update - nexus, selective api call (cherry picked from commit 39fbfcb) * fix: sales_tax attribute in api call before submit (cherry picked from commit 7ddc460) * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit a8e9e72) * Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit afce0d3) * Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.js Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 569cf43) * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit ecb92e9) * fix: Renamed child table doctype, delete taxes for non nexus state (cherry picked from commit 3cbae8d) * fix: updated patch, add fields only if fields are checked (cherry picked from commit 6ddd55a) # Conflicts: # erpnext/patches/v13_0/custom_fields_for_taxjar_integration.py * fix: patch fix, fields disabling (cherry picked from commit 4536ab2) * fix: using db.exists and get_value instead of get_doc (cherry picked from commit 3337afe) * fix: dt instead of document in set_value query (cherry picked from commit 93a30f4) * minor fixes (cherry picked from commit 7ddc208) * fix: improved on_update method, added validation for tax calculation, sandbox mode checks (cherry picked from commit 17501ba) * fix: linters fix (cherry picked from commit dc20387) * fix: patch fix added reload_doctype (cherry picked from commit a183cfc) * fix: patch fixes- force reload doc, check for company (cherry picked from commit 1799b55) * fix: 'Taxjar' type fix (cherry picked from commit 076c83c) * fix: Update pacthes.txt (cherry picked from commit 64f92fe) * fix: Patch (cherry picked from commit 89ad53d) # Conflicts: # erpnext/patches.txt * fix: Move product tax category folder to taxjar settings (cherry picked from commit adfa239) * Update custom_fields_for_taxjar_integration.py * fix: conflicts * fix: linter issues removed extra line * fix: patch fix einvoicing deprecation patch removed Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>

fix: TaxJar update - nexus, selective api call

b01fe1c

nemesis189 requested a review from deepeshgarg007 September 14, 2021 15:18

nemesis189 requested a review from nextchamp-saqib as a code owner September 14, 2021 15:18

fix: sales_tax attribute in api call before submit

3bb60a4

deepeshgarg007 requested changes Sep 16, 2021

View reviewed changes

nemesis189 and others added 5 commits September 16, 2021 14:41

Update erpnext/erpnext_integrations/taxjar_integration.py

0e52731

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_se…

486d7c3

…ttings.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

Update erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_se…

435a5e4

…ttings.js Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

Update erpnext/erpnext_integrations/taxjar_integration.py

11bd424

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

fix: Renamed child table doctype, delete taxes for non nexus state

5c18654

nemesis189 requested a review from deepeshgarg007 September 17, 2021 04:51

nemesis189 marked this pull request as draft September 20, 2021 10:20

nemesis189 added 2 commits September 27, 2021 12:51

fix: updated patch, add fields only if fields are checked

54754f4

fix: patch fix, fields disabling

0a28fed

Alchez suggested changes Sep 28, 2021

View reviewed changes

nemesis189 added 3 commits September 29, 2021 11:11

fix: using db.exists and get_value instead of get_doc

8675ca5

fix: dt instead of document in set_value query

d3bb920

minor fixes

254b20b

deepeshgarg007 reviewed Oct 4, 2021

View reviewed changes

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py Outdated Show resolved Hide resolved

deepeshgarg007 reviewed Oct 4, 2021

View reviewed changes

erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py Outdated Show resolved Hide resolved

nemesis189 added 2 commits October 6, 2021 21:31

fix: improved on_update method, added validation for tax calculation,…

7114659

… sandbox mode checks

fix: linters fix

3ece05a

nemesis189 removed the request for review from nextchamp-saqib October 6, 2021 16:07

fix: patch fix added reload_doctype

eaa3614

deepeshgarg007 requested changes Oct 10, 2021

View reviewed changes

erpnext/patches/v13_0/custom_fields_for_taxjar_integration.py Outdated Show resolved Hide resolved

erpnext/patches/v13_0/custom_fields_for_taxjar_integration.py Outdated Show resolved Hide resolved

nemesis189 added 2 commits October 11, 2021 10:20

fix: patch fixes- force reload doc, check for company

1b25e69

fix: 'Taxjar' type fix

ea20384

Alchez reviewed Oct 11, 2021

View reviewed changes

fix: Update pacthes.txt

5d4c919

deepeshgarg007 marked this pull request as ready for review October 13, 2021 06:45

deepeshgarg007 added 2 commits October 13, 2021 13:24

fix: Patch

2d19e2d

fix: Move product tax category folder to taxjar settings

bd8cfb2

deepeshgarg007 approved these changes Oct 13, 2021

View reviewed changes

deepeshgarg007 merged commit bd8dda2 into frappe:develop Oct 13, 2021

mergify bot mentioned this pull request Oct 13, 2021

fix: TaxJar update - added nexus list, making api call only for nexus (backport #27497) #27940

Merged

rohitwaghchaure mentioned this pull request Nov 9, 2021

chore: Added change log for version 13.14.0 #28305

Merged

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021

Merge pull request frappe#27497 from nemesis189/taxjar-nexus-update

a141b43

fix: TaxJar update - added nexus list, making api call only for nexus

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: TaxJar update - added nexus list, making api call only for nexus #27497

fix: TaxJar update - added nexus list, making api call only for nexus #27497

nemesis189 commented Sep 14, 2021 •

edited

Alchez Oct 11, 2021

deepeshgarg007 commented Oct 13, 2021

mergify bot commented Oct 13, 2021

mergify bot commented Oct 13, 2021

fix: TaxJar update - added nexus list, making api call only for nexus #27497

fix: TaxJar update - added nexus list, making api call only for nexus #27497

Conversation

nemesis189 commented Sep 14, 2021 • edited

Alchez Oct 11, 2021

Choose a reason for hiding this comment

deepeshgarg007 commented Oct 13, 2021

mergify bot commented Oct 13, 2021

mergify bot commented Oct 13, 2021

nemesis189 commented Sep 14, 2021 •

edited