fix: Validate if item exists on uploading items in stock reco #27538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uploading non existent item in stock reco and then changing warehouse or batch gave an error - Check for non existent item
This comment has been minimized.
This comment has been minimized.
szufisher
reviewed
Sep 16, 2021
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
Outdated
Show resolved
Hide resolved
ankush
reviewed
Sep 16, 2021
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
Outdated
Show resolved
Hide resolved
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
Outdated
Show resolved
Hide resolved
ankush
approved these changes
Sep 16, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 16, 2021
…#27538) * fix: Validate if item exists on uploading items in stock reco - Uploading non existent item in stock reco and then changing warehouse or batch gave an error - Check for non existent item * chore: translation Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit 9b38888)
|
@ankush yes that will be good and also maybe a hook that can enable us to write custom checks too ? Because unlike data import this import doesn't give that error traceback bit (if i'm not wrong),and causes a lot of type issues too (historically) like comparison between |
|
@Mergifyio backport version-12-hotfix |
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
* fix: Validate if item exists on uploading items in stock reco - Uploading non existent item in stock reco and then changing warehouse or batch gave an error - Check for non existent item * chore: translation Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit 9b38888)
|
Command
|
ankush
pushed a commit
that referenced
this pull request
Sep 20, 2021
#27593) * fix: Validate if item exists on uploading items in stock reco - Uploading non existent item in stock reco and then changing warehouse or batch gave an error - Check for non existent item * chore: translation Co-authored-by: Marica <maricadsouza221197@gmail.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…#27538) * fix: Validate if item exists on uploading items in stock reco - Uploading non existent item in stock reco and then changing warehouse or batch gave an error - Check for non existent item * chore: translation Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Uploading (via Upload button) non existent item in stock reco and then changing warehouse or batch (trigger JS action) gave an error: