Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset): expected value after useful life validation #27539

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Sep 16, 2021

For an existing Asset with,
Gross Purchase Amount - 10,000, Opening Accumulated Depreciation - 1,000, No. of Depreciation booked - 2

Creating a Depreciation Schedule for this asset with Straight Line method and with 2,000 as Expected Value after Useful Life value throws an error - "Expected value after useful life must be greater than or equal to 4000.0"

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #27539 (033e59e) into develop (f8c1c73) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           develop   #27539     +/-   ##
==========================================
  Coverage    54.49%   54.49%             
==========================================
  Files         1333     1248     -85     
  Lines        70736    67514   -3222     
==========================================
- Hits         38545    36793   -1752     
+ Misses       32191    30721   -1470     
Impacted Files Coverage Δ
erpnext/assets/doctype/asset/asset.py 71.60% <50.00%> (-0.36%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/hr/doctype/job_applicant/job_applicant.py 48.21% <0.00%> (-32.35%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 68.22% <0.00%> (-2.56%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
... and 159 more

@nextchamp-saqib nextchamp-saqib merged commit 065a2ce into frappe:develop Oct 5, 2021
mergify bot pushed a commit that referenced this pull request Oct 5, 2021
mergify bot pushed a commit that referenced this pull request Oct 5, 2021
AfshanKhan pushed a commit that referenced this pull request Oct 5, 2021
)

(cherry picked from commit 065a2ce)

Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
pateljannat pushed a commit to pateljannat/erpnext that referenced this pull request Oct 11, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants