-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot add deductions in internal transfer payment entry #27545
fix: cannot add deductions in internal transfer payment entry #27545
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27545 +/- ##
===========================================
- Coverage 54.49% 54.46% -0.04%
===========================================
Files 1248 1254 +6
Lines 67515 67745 +230
===========================================
+ Hits 36793 36894 +101
- Misses 30722 30851 +129
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
46139e3
to
1b7414e
Compare
@Mergifyio backport version-13-hotfix |
Command
|
Command
|
#27545) (#27930) * fix: cannot add deductions in internal transfer payment entry (cherry picked from commit 1b7414e) # Conflicts: # erpnext/accounts/doctype/payment_entry/payment_entry.py * fix: Update message string (cherry picked from commit 3b9514d) # Conflicts: # erpnext/accounts/doctype/payment_entry/payment_entry.py * fix: conflicts Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
…-fix fix: cannot add deductions in internal transfer payment entry
Due to recent changes from 7141860, the
received_amount
was being set aspaid_amount
even if there were deductions such as transfer fees was added to the payment entry.To replicate the issue:
Expected Behaviour: