Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ux): warn when overbilling allowance was bypassed due to role #27601

Merged
merged 4 commits into from
Sep 20, 2021
Merged

fix(ux): warn when overbilling allowance was bypassed due to role #27601

merged 4 commits into from
Sep 20, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Sep 20, 2021 •
edited

Change:

  • Show message when user has overbilled but system ignored it due to their role.
  • Refactor code (excessive indentation)
  • minor perf changes - extract loop invariants like global settings and user's roles.

Screenshot 2021-09-20 at 4 30 47 PM

@ankush
Copy link
Member Author

ankush commented Sep 20, 2021

@Mergifyio backport version-12-hotfix version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2021

Command backport version-12-hotfix version-13-hotfix: pending

backport version-12-hotfix version-13-hotfix is pending

@ankush @nextchamp-saqib
fix(ux): better error message
21a955d 
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
@codecov

This comment has been minimized.

Sign in to view
@ankush ankush merged commit 4f01115 into frappe:develop Sep 20, 2021
@ankush ankush deleted the overbill_warn branch September 20, 2021 12:13
This was referenced Sep 20, 2021
Closed
Merged
@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2021

Command backport version-12-hotfix version-13-hotfix: success

Backports have been created

ankush added a commit that referenced this pull request Sep 20, 2021
@ankush
Merge pull request #27604 from frappe/mergify/bp/version-13-hotfix/pr…
72c22a4 
…-27601

fix(ux): warn when overbilling allowance was bypassed due to role (backport #27601)
@ankush ankush mentioned this pull request Oct 26, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
Merge pull request frappe#27601 from ankush/overbill_warn
7c399b8 
fix(ux): warn when overbilling allowance was bypassed due to role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib nextchamp-saqib left review comments

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankush @nextchamp-saqib