Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): overbiling message in SO->SI, PO->PI #28088

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 26, 2021

Extending #27601 for other workflows.

Also, made it less annoying by using alert instead of msgprint.

Screenshot 2021-10-26 at 8 58 39 PM

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #28088 (8dbdb9a) into develop (fc83076) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #28088      +/-   ##
===========================================
+ Coverage    55.16%   55.18%   +0.01%     
===========================================
  Files         1255     1255              
  Lines        67877    67895      +18     
===========================================
+ Hits         37446    37466      +20     
+ Misses       30431    30429       -2     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 83.56% <ø> (ø)
erpnext/controllers/status_updater.py 85.71% <50.00%> (-1.86%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-22.04%) ⬇️
erpnext/stock/stock_ledger.py 85.53% <0.00%> (-1.81%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/projects/doctype/project/project.py 53.90% <0.00%> (-0.36%) ⬇️
erpnext/stock/get_item_details.py 79.53% <0.00%> (-0.31%) ⬇️
...x_withholding_category/tax_withholding_category.py 85.78% <0.00%> (-0.01%) ⬇️
erpnext/stock/reorder_item.py 77.11% <0.00%> (ø)
... and 14 more

@ankush ankush merged commit 6ec047c into frappe:develop Oct 27, 2021
mergify bot pushed a commit that referenced this pull request Oct 27, 2021
ankush added a commit that referenced this pull request Oct 27, 2021
(cherry picked from commit 6ec047c)

Co-authored-by: Ankush Menat <ankush@frappe.io>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
(cherry picked from commit 6ec047c)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant