Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trim sales invoice custom field lengths #27665

Merged
merged 4 commits into from
Oct 2, 2021
Merged

fix: trim sales invoice custom field lengths #27665

merged 4 commits into from
Oct 2, 2021

Conversation

nextchamp-saqib
Copy link
Member

Applies #27136 just on custom field

@nextchamp-saqib nextchamp-saqib added the needs-patch A patch to fix existing data is required label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021 •
edited

Codecov Report

Merging #27665 (83cc597) into develop (b39f8a6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27665      +/-   ##
===========================================
- Coverage    54.54%   54.53%   -0.02%     
===========================================
  Files         1333     1334       +1     
  Lines        70737    70759      +22     
===========================================
+ Hits         38583    38585       +2     
- Misses       32154    32174      +20
Impacted Files Coverage Δ
erpnext/regional/india/setup.py 95.31% <100.00%> (+0.07%) ⬆️
...eport/item_variant_details/item_variant_details.py 32.14% <0.00%> (-52.39%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.20% <0.00%> (-3.60%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.50% <0.00%> (-2.50%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/reorder_item.py 76.10% <0.00%> (-0.89%) ⬇️
.../support/report/issue_analytics/issue_analytics.py 89.16% <0.00%> (-0.84%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.48% <0.00%> (-0.38%) ⬇️
... and 26 more

@nextchamp-saqib nextchamp-saqib removed the needs-patch A patch to fix existing data is required label Sep 29, 2021
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 197e97d into frappe:develop Oct 2, 2021
@mergify mergify bot mentioned this pull request Oct 2, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2021

Command backport version-13-hotfix: success

Backports have been created

@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed.
Please backport the PR manually. 🤖

The process '/usr/bin/git' failed with exit code 1

AfshanKhan added a commit that referenced this pull request Oct 7, 2021
@mergify @nextchamp-saqib
@deepeshgarg007 @AfshanKhan
fix: trim sales invoice custom field lengths (backport #27665) (#27750)
4102f79 
* fix: trim sales invoice custom field lengths

(cherry picked from commit a7df422)

* patch: trim sales invoice custom field lengths

(cherry picked from commit f1fcb38)

# Conflicts:
#	erpnext/patches.txt

* fix: do not set length for date field

(cherry picked from commit 83cc597)

* fix: merge conflicts

Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@deepeshgarg007
Merge pull request frappe#27665 from nextchamp-saqib/trim-custom-fiel…
f3858d9 
…d-length

fix: trim sales invoice custom field lengths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush left review comments

@deepeshgarg007 deepeshgarg007 deepeshgarg007 approved these changes

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nextchamp-saqib @deepeshgarg007 @frappe-pr-bot @ankush