Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tracking Multi-round interview (backport #25482) #27724

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2021

This is an automatic backport of pull request #25482 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* feat: Tracking Multi-round interview

* fix: releted to scheduler event and formating

* fix: job applicant UI/UX and conflicts

* test: Interview Round

* fix(test): Employee referral, Employee Onboarding, Job Offer

* fix: sider

* feat: set default value in Hr settings

* feat: added validation for designation

* test: Interview

* test: Added validatiolns for skill

* test: Interview feedback

* fix: sider

* fix: remove unnecessary validations and form label cleanups

* chore: clean-up Interview Round and Interview Type doctype

* fix: remove redundant Rating Value, only keep Rating

* fix: update interview details on feedback submission

- make interview feedback submission dialog minimizable

* fix: show submit feedback button only if feedback doesn't exist

* refactor: Interview and Feedback statuses and workflow

* fix(HR Settings): clean up interview settings

* refactor: Interview

* refactor: Interview Feedback, remove unnecessary validations

* chore: update notification messages

* chore: remove unnecessary formatting changes in attendance list and leave application

* refactor: Job Applicant to Interview mapping

* chore: sorted imports

* chore: sorted imports

* fix: sider issues

* fix: linter issues

* fix: sider issues

* fix: tests

* fix: sorted imports

* fix: tests, sider

* fix: therapy plan test

* fix: sider issues

* feat: Include From Time and To Time fields in Interview for cleaner data

* feat: Interview Calendar

* fix: allow renaming masters

* fix: add more fields to list view and standard filter

* fix: validate overlapping interviews

* fix: update tests

* fix: linter issues

* refactor: replace reminder messages with Email Templates

* fix: sider issues

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 57e66f9)
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #27724 (4426875) into develop (9e08229) will increase coverage by 0.09%.
The diff coverage is 66.16%.

@@             Coverage Diff             @@
##           develop   #27724      +/-   ##
===========================================
+ Coverage    54.57%   54.66%   +0.09%     
===========================================
  Files         1334     1342       +8     
  Lines        70757    71010     +253     
===========================================
+ Hits         38617    38821     +204     
- Misses       32140    32189      +49     
Impacted Files Coverage Δ
erpnext/hooks.py 0.00% <ø> (ø)
...xt/setup/setup_wizard/operations/defaults_setup.py 0.00% <0.00%> (ø)
erpnext/hr/doctype/job_applicant/job_applicant.py 48.21% <14.81%> (-32.35%) ⬇️
...next/hr/doctype/interview_round/interview_round.py 38.88% <38.88%> (ø)
erpnext/hr/doctype/interview/interview.py 61.90% <61.90%> (ø)
...r/doctype/interview_feedback/interview_feedback.py 94.54% <94.54%> (ø)
...xt/healthcare/doctype/therapy_plan/therapy_plan.py 100.00% <100.00%> (ø)
.../hr/doctype/employee_referral/employee_referral.py 96.07% <100.00%> (+0.16%) ⬆️
...r/doctype/expected_skill_set/expected_skill_set.py 100.00% <100.00%> (ø)
...xt/hr/doctype/interview_detail/interview_detail.py 100.00% <100.00%> (ø)
... and 23 more

@ruchamahabal ruchamahabal merged commit b9942ad into develop Oct 1, 2021
@mergify mergify bot deleted the mergify/bp/develop/pr-25482 branch October 1, 2021 07:46
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* feat: Tracking Multi-round interview

* fix: releted to scheduler event and formating

* fix: job applicant UI/UX and conflicts

* test: Interview Round

* fix(test): Employee referral, Employee Onboarding, Job Offer

* fix: sider

* feat: set default value in Hr settings

* feat: added validation for designation

* test: Interview

* test: Added validatiolns for skill

* test: Interview feedback

* fix: sider

* fix: remove unnecessary validations and form label cleanups

* chore: clean-up Interview Round and Interview Type doctype

* fix: remove redundant Rating Value, only keep Rating

* fix: update interview details on feedback submission

- make interview feedback submission dialog minimizable

* fix: show submit feedback button only if feedback doesn't exist

* refactor: Interview and Feedback statuses and workflow

* fix(HR Settings): clean up interview settings

* refactor: Interview

* refactor: Interview Feedback, remove unnecessary validations

* chore: update notification messages

* chore: remove unnecessary formatting changes in attendance list and leave application

* refactor: Job Applicant to Interview mapping

* chore: sorted imports

* chore: sorted imports

* fix: sider issues

* fix: linter issues

* fix: sider issues

* fix: tests

* fix: sorted imports

* fix: tests, sider

* fix: therapy plan test

* fix: sider issues

* feat: Include From Time and To Time fields in Interview for cleaner data

* feat: Interview Calendar

* fix: allow renaming masters

* fix: add more fields to list view and standard filter

* fix: validate overlapping interviews

* fix: update tests

* fix: linter issues

* refactor: replace reminder messages with Email Templates

* fix: sider issues

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 423db47)

Co-authored-by: Anurag Mishra <32095923+Anurag810@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants