Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Clean up mutable defaults and add CI check #27828

Merged
merged 3 commits into from
Oct 6, 2021
Merged

refactor: Clean up mutable defaults and add CI check #27828

merged 3 commits into from
Oct 6, 2021

Conversation

ChillarAnand
Copy link
Contributor

No description provided.

@ankush

This comment has been minimized.

Sign in to view
@ChillarAnand ChillarAnand marked this pull request as ready for review October 6, 2021 12:33
@ankush ankush self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited

Codecov Report

Merging #27828 (5b4735c) into develop (d4b2471) will increase coverage by 54.53%.
The diff coverage is 60.00%.

❗ Current head 5b4735c differs from pull request most recent head 5e5e640. Consider uploading reports for the commit 5e5e640 to get more accurate results

@@             Coverage Diff              @@
##           develop   #27828       +/-   ##
============================================
+ Coverage         0   54.53%   +54.53%     
============================================
  Files            0     1248     +1248     
  Lines            0    67544    +67544     
============================================
+ Hits             0    36834    +36834     
- Misses           0    30710    +30710
Impacted Files Coverage Δ
erpnext/accounts/report/cash_flow/cash_flow.py 0.00% <0.00%> (ø)
erpnext/stock/doctype/serial_no/serial_no.py 78.92% <33.33%> (ø)
...stock/doctype/material_request/material_request.py 70.32% <50.00%> (ø)
...xt/hr/doctype/shift_assignment/shift_assignment.py 49.07% <55.55%> (ø)
erpnext/hr/doctype/staffing_plan/staffing_plan.py 91.13% <60.00%> (ø)
erpnext/accounts/doctype/pricing_rule/utils.py 70.16% <66.66%> (ø)
erpnext/education/doctype/student/student.py 73.95% <66.66%> (ø)
...s/doctype/promotional_scheme/promotional_scheme.py 96.93% <75.00%> (ø)
erpnext/hr/doctype/holiday_list/holiday_list.py 80.95% <100.00%> (ø)
erpnext/stock/get_item_details.py 79.53% <100.00%> (ø)
... and 1248 more

@ankush ankush enabled auto-merge (squash) October 6, 2021 16:52
@ankush ankush merged commit 772d475 into frappe:develop Oct 6, 2021
mergify bot pushed a commit that referenced this pull request Oct 6, 2021
@ChillarAnand
refactor: Clean up mutable defaults and add CI check (#27828)
aa36b97 
* refactor: Clean up mutable defaults and add CI check

(cherry picked from commit 772d475)
@mergify mergify bot mentioned this pull request Oct 6, 2021
Merged
@ChillarAnand ChillarAnand deleted the flake8 branch October 7, 2021 02:11
ankush pushed a commit that referenced this pull request Oct 7, 2021
@mergify @ChillarAnand
refactor: Clean up mutable defaults and add CI check (#27828) (#27841)
dd0cefb 
* refactor: Clean up mutable defaults and add CI check

(cherry picked from commit 772d475)

Co-authored-by: Chillar Anand <chillar@avilpage.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ChillarAnand
refactor: Clean up mutable defaults and add CI check (frappe#27828)
ee88207 
* refactor: Clean up mutable defaults and add CI check
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

Assignees

@ankush ankush

Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChillarAnand @ankush