Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bom item query #27890

Merged
merged 3 commits into from
Oct 11, 2021
Merged

fix: bom item query #27890

merged 3 commits into from
Oct 11, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 11, 2021 •
edited

@ankush ankush added backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. labels Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #27890 (e014f5e) into develop (6019f60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #27890   +/-   ##
========================================
  Coverage    54.55%   54.56%           
========================================
  Files         1248     1248           
  Lines        67518    67517    -1     
========================================
+ Hits         36836    36839    +3     
+ Misses       30682    30678    -4
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 86.87% <100.00%> (+2.94%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-22.04%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.50% <0.00%> (-2.50%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/stock/reorder_item.py 74.57% <0.00%> (-1.70%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.66% <0.00%> (-0.09%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.31% <0.00%> (ø)
erpnext/stock/get_item_details.py 79.53% <0.00%> (+0.15%) ⬆️
... and 8 more

@ankush ankush merged commit 0a3dd3e into frappe:develop Oct 11, 2021
mergify bot pushed a commit that referenced this pull request Oct 11, 2021
@ankush
fix: bom item query #27890
929feb4 
fix: bom item query
(cherry picked from commit 0a3dd3e)

# Conflicts:
#	erpnext/manufacturing/doctype/bom/test_bom.py
@mergify mergify bot mentioned this pull request Oct 11, 2021
Merged
ankush added a commit that referenced this pull request Oct 11, 2021
@mergify @ankush
fix: bom item query (backport #27890) (#27894)
a831e6b 
* fix: bom item query #27890

fix: bom item query
(cherry picked from commit 0a3dd3e)

# Conflicts:
#	erpnext/manufacturing/doctype/bom/test_bom.py

* fix: resolve conflict

* chore: unused imports

[skip ci]

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
@ankush ankush mentioned this pull request Oct 13, 2021
Closed
@ankush ankush deleted the test_bom_query branch October 21, 2021 18:56
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
fix: bom item query frappe#27890
92c8a1a 
fix: bom item query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ankush