fix: v12 migrate error - unknown column ‘mandatory_depends_on’ #27897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport version-12-hotfix version-13-hotfix |
|
Command
|
Codecov Report
@@ Coverage Diff @@
## develop #27897 +/- ##
===========================================
+ Coverage 54.39% 54.41% +0.01%
===========================================
Files 1254 1254
Lines 67717 67717
===========================================
+ Hits 36838 36845 +7
+ Misses 30879 30872 -7
|
ankush
reviewed
Oct 11, 2021
ankush
previously approved these changes
Oct 11, 2021
auto-merge was automatically disabled
October 11, 2021 08:52
Head branch was pushed to by a user without write access
rtdany10
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
|
@ankush Linters failing due to another piece of code. |
Have fixed this. Can merge now :) |
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
* fix: v12 doesn't have mandatory_depends_on field * fix: move update_vehicle_no_reqd_condition to v13 * fix: move update_vehicle_no_reqd_condition to v13 * fix: file name missing .py * refactor!: add back empty line * fix: linters issue (cherry picked from commit 7acdcc7) # Conflicts: # erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.py # erpnext/patches.txt # erpnext/patches/v13_0/update_vehicle_no_reqd_condition.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
* fix: v12 doesn't have mandatory_depends_on field * fix: move update_vehicle_no_reqd_condition to v13 * fix: move update_vehicle_no_reqd_condition to v13 * fix: file name missing .py * refactor!: add back empty line * fix: linters issue (cherry picked from commit 7acdcc7) # Conflicts: # erpnext/patches.txt
|
Command
|
ankush
added a commit
that referenced
this pull request
Oct 11, 2021
…ort #27897) (#27900) * fix: v12 migrate error - unknown column ‘mandatory_depends_on’ (#27897) * fix: v12 doesn't have mandatory_depends_on field * fix: move update_vehicle_no_reqd_condition to v13 * fix: move update_vehicle_no_reqd_condition to v13 * fix: file name missing .py * refactor!: add back empty line * fix: linters issue (cherry picked from commit 7acdcc7) # Conflicts: # erpnext/patches.txt * fix: resolve conflicts Co-authored-by: Dany Robert <rtdany10@gmail.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…e#27897) * fix: v12 doesn't have mandatory_depends_on field * fix: move update_vehicle_no_reqd_condition to v13 * fix: move update_vehicle_no_reqd_condition to v13 * fix: file name missing .py * refactor!: add back empty line * fix: linters issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v12 doesn't have mandatory_depends_on field.
Removed a patch that referenced to the said field on v12.
Closes frappe/frappe#14335 (comment)