Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor ux fixes in Sales & Purchase Invoice #27927

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Oct 12, 2021

Splitting & moving sections to keep them consistent through Sales & Purchase Invoice

  • Moved Write-Off section of Sales Invoice up right after Grand Total (as it is in Purchase Invoice)
  • Changed label Is Opening to Is Opening Entry (as it is in Sales Invoice)
  • Split More Information section of Purchase Invoice (as it is in Sales Invoice)
Before
Purchase Invoice :-

Screenshot 2021-10-12 at 8 31 49 PM

Sales Invoice :-

Screenshot 2021-10-12 at 8 36 27 PM

After

Purchase Invoice :-

Screenshot 2021-10-12 at 9 05 59 PM

Sales Invoice :-

Screenshot 2021-10-12 at 1 01 55 PM

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #27927 (b7769c7) into develop (b6da7ff) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27927      +/-   ##
===========================================
+ Coverage    54.38%   54.45%   +0.06%     
===========================================
  Files         1254     1254              
  Lines        67745    67745              
===========================================
+ Hits         36846    36891      +45     
+ Misses       30899    30854      -45     
Impacted Files Coverage Δ
erpnext/stock/reorder_item.py 75.42% <0.00%> (-2.55%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 78.33% <0.00%> (-2.50%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/stock_ledger.py 85.89% <0.00%> (-0.91%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 90.64% <0.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.75% <0.00%> (+0.08%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (+0.26%) ⬆️
erpnext/projects/doctype/project/project.py 54.25% <0.00%> (+0.35%) ⬆️
erpnext/selling/doctype/sales_order/sales_order.py 77.13% <0.00%> (+0.37%) ⬆️
... and 10 more

@deepeshgarg007 deepeshgarg007 merged commit 0b263c5 into frappe:develop Oct 12, 2021
@Anuja-pawar
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

Command backport version-13-hotfix: success

Backports have been created

AfshanKhan pushed a commit that referenced this pull request Oct 13, 2021
…7932)

* fix: keeping sections consistent across sales & purchase invoice

(cherry picked from commit 2bc1ca9)

* fix: set collapsible & print hide

(cherry picked from commit d181cc4)

Co-authored-by: Anuja Pawar <anuja.pawar20@gmail.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix: minor ux fixes in Sales & Purchase Invoice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants