Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: POS Profile payment methods table #27956

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

nemesis189
Copy link
Contributor

Problem:
When creating a new POS Profile, after entering the name, warehouse, write off account and write off cost centre, if we do not add mode of payment, we get this validation:

Before:
After fix:

@AfshanKhan
Copy link
Contributor

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #27956 (789e3d4) into develop (c0e6328) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27956      +/-   ##
===========================================
+ Coverage    54.39%   54.41%   +0.02%     
===========================================
  Files         1255     1255              
  Lines        67817    67817              
===========================================
+ Hits         36891    36905      +14     
+ Misses       30926    30912      -14     
Impacted Files Coverage Δ
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.31% <0.00%> (-1.30%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 78.62% <0.00%> (-0.69%) ⬇️
erpnext/stock/stock_ledger.py 86.25% <0.00%> (-0.55%) ⬇️
erpnext/stock/get_item_details.py 79.38% <0.00%> (-0.47%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (-0.44%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 71.09% <0.00%> (+0.23%) ⬆️
erpnext/stock/report/stock_ledger/stock_ledger.py 80.00% <0.00%> (+1.66%) ⬆️
... and 4 more

@AfshanKhan AfshanKhan merged commit f3cf36f into frappe:develop Oct 15, 2021
mergify bot pushed a commit that referenced this pull request Oct 15, 2021
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
(cherry picked from commit f3cf36f)
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

Command backport version-13-hotfix: success

Backports have been created

AfshanKhan pushed a commit that referenced this pull request Oct 15, 2021
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
(cherry picked from commit f3cf36f)

Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
(cherry picked from commit f3cf36f)

Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants