-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: POS Profile payment methods table #27956
Merged
AfshanKhan
merged 2 commits into
frappe:develop
from
nemesis189:pos-profile-payment-table-label
Oct 15, 2021
Merged
fix: POS Profile payment methods table #27956
AfshanKhan
merged 2 commits into
frappe:develop
from
nemesis189:pos-profile-payment-table-label
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport version-13-hotfix |
AfshanKhan
approved these changes
Oct 15, 2021
Command
|
Codecov Report
@@ Coverage Diff @@
## develop #27956 +/- ##
===========================================
+ Coverage 54.39% 54.41% +0.02%
===========================================
Files 1255 1255
Lines 67817 67817
===========================================
+ Hits 36891 36905 +14
+ Misses 30926 30912 -14
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> (cherry picked from commit f3cf36f)
Command
|
AfshanKhan
pushed a commit
that referenced
this pull request
Oct 15, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> (cherry picked from commit f3cf36f) Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When creating a new POS Profile, after entering the name, warehouse, write off account and write off cost centre, if we do not add mode of payment, we get this validation:
Before:
After fix: