-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changes in schedules gets overwritten on save #27990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahjacob
requested review from
marination and
rohitwaghchaure
as code owners
October 18, 2021 08:36
noahjacob
force-pushed
the
maint_schedule_fix
branch
from
October 18, 2021 09:39
0d87554
to
a002369
Compare
Codecov Report
@@ Coverage Diff @@
## develop #27990 +/- ##
===========================================
- Coverage 54.40% 54.35% -0.06%
===========================================
Files 1255 1255
Lines 67819 67822 +3
===========================================
- Hits 36900 36867 -33
- Misses 30919 30955 +36
|
ankush
reviewed
Oct 18, 2021
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
Outdated
Show resolved
Hide resolved
noahjacob
force-pushed
the
maint_schedule_fix
branch
from
October 19, 2021 06:38
a002369
to
af1b9e1
Compare
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions
|
✅ Backports have been created
|
✅ Backports have been created
|
noahjacob
added a commit
that referenced
this pull request
Oct 19, 2021
…se/pr-27990 fix: changes in schedules gets overwritten on save (backport #27990)
noahjacob
pushed a commit
that referenced
this pull request
Oct 19, 2021
…-27990 fix: changes in schedules gets overwritten on save (backport #27990)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…fix/pr-27990 fix: changes in schedules gets overwritten on save (backport frappe#27990)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix