Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes in schedules gets overwritten on save #27990

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

noahjacob
Copy link
Contributor

@noahjacob noahjacob commented Oct 18, 2021

Issue

  • Any changes made to the schedule table would get overwritten since generate schedule is called on save.

main_bug

Fix

  • While validating, only call generate schedule if schedule table is empty or of no of visits are changed.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #27990 (e08a099) into develop (7717b99) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27990      +/-   ##
===========================================
- Coverage    54.40%   54.35%   -0.06%     
===========================================
  Files         1255     1255              
  Lines        67819    67822       +3     
===========================================
- Hits         36900    36867      -33     
- Misses       30919    30955      +36     
Impacted Files Coverage Δ
...ctype/maintenance_schedule/maintenance_schedule.py 75.65% <100.00%> (-0.12%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/stock/reorder_item.py 75.42% <0.00%> (-0.85%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.39% <0.00%> (-0.75%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.92% <0.00%> (-0.72%) ⬇️
... and 12 more

@noahjacob
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport version-13-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@noahjacob
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport version-13-pre-release

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport version-13-hotfix

✅ Backports have been created

noahjacob added a commit that referenced this pull request Oct 19, 2021
…se/pr-27990

fix: changes in schedules gets overwritten on save (backport #27990)
noahjacob pushed a commit that referenced this pull request Oct 19, 2021
…-27990

fix: changes in schedules gets overwritten on save (backport #27990)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27990

fix: changes in schedules gets overwritten on save (backport frappe#27990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants