Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enabled field in UOM #27993

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

hrwX
Copy link
Contributor

@hrwX hrwX commented Oct 18, 2021

Changes:

  • Add "enabled" checkbox. All UOMs are enabled by default.
  • Unchecking the checkbox hides UOM from showing up in suggestions in link fields.

Related: frappe/frappe#14484

no-docs

@hrwX hrwX force-pushed the add_enabled_field branch 2 times, most recently from 2b66322 to d9a652f Compare October 18, 2021 12:51
@barredterra
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #27993 (46bd0c4) into develop (9c54d6d) will increase coverage by 13.71%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #27993       +/-   ##
============================================
+ Coverage    40.71%   54.42%   +13.71%     
============================================
  Files         1255     1255               
  Lines        67819    67819               
============================================
+ Hits         27612    36911     +9299     
+ Misses       40207    30908     -9299     
Impacted Files Coverage Δ
erpnext/projects/doctype/project/project.py 53.90% <0.00%> (ø)
erpnext/assets/doctype/asset/asset.py 71.60% <0.00%> (+0.20%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (+0.26%) ⬆️
erpnext/portal/product_configurator/utils.py 33.46% <0.00%> (+0.40%) ⬆️
erpnext/controllers/buying_controller.py 86.42% <0.00%> (+0.47%) ⬆️
erpnext/controllers/item_variant.py 71.06% <0.00%> (+0.50%) ⬆️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 70.44% <0.00%> (+0.55%) ⬆️
erpnext/accounts/party.py 76.74% <0.00%> (+0.58%) ⬆️
..._scorecard_variable/supplier_scorecard_variable.py 25.54% <0.00%> (+0.72%) ⬆️
erpnext/projects/doctype/timesheet/timesheet.py 79.35% <0.00%> (+0.80%) ⬆️
... and 291 more

@ankush ankush merged commit 7717b99 into frappe:develop Oct 19, 2021
mergify bot pushed a commit that referenced this pull request Oct 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport version-13-hotfix

✅ Backports have been created

AfshanKhan pushed a commit that referenced this pull request Oct 19, 2021
(cherry picked from commit 7717b99)

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
(cherry picked from commit 7717b99)

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
@ankush ankush mentioned this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable UOM
3 participants