fix: avoid resetting employee on amending timesheets #28025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
timesheet-fix
branch
from
38bd3aa
to
fd1c154
Compare
|
@Mergifyio backport version-13-hotfix |
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
(cherry picked from commit 261f80c)
✅ Backports have been created
|
ruchamahabal
added a commit
that referenced
this pull request
Oct 20, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…rappe#28026) (cherry picked from commit 261f80c) Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Fix:
If a timesheet with employee field set is amended, it resets employee details and since it is a non-mandatory field user can miss this, save and submit the timesheet without setting the employee again. This is because the timesheet tries to set the employee from session user on load.
After Fix:
Don't reset employee details if already set