-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consolidated report issue #28035
Merged
ankush
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-consolidated-report
Oct 20, 2021
Merged
fix: consolidated report issue #28035
ankush
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-consolidated-report
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rohitwaghchaure
commented
Oct 20, 2021
rohitwaghchaure
requested review from
ankush,
deepeshgarg007,
marination and
nextchamp-saqib
as code owners
October 20, 2021 14:47
ankush
reviewed
Oct 20, 2021
erpnext/manufacturing/doctype/production_plan/production_plan.py
Outdated
Show resolved
Hide resolved
rohitwaghchaure
force-pushed
the
fixed-consolidated-report
branch
from
October 20, 2021 14:57
d7cd148
to
e92464e
Compare
sagarvora
reviewed
Oct 20, 2021
erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.py
Outdated
Show resolved
Hide resolved
rohitwaghchaure
force-pushed
the
fixed-consolidated-report
branch
from
October 20, 2021 15:14
e92464e
to
5fa7962
Compare
rohitwaghchaure
force-pushed
the
fixed-consolidated-report
branch
from
October 20, 2021 15:15
5fa7962
to
038a3c5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28035 +/- ##
===========================================
+ Coverage 54.41% 55.16% +0.75%
===========================================
Files 1255 1255
Lines 67817 67851 +34
===========================================
+ Hits 36900 37428 +528
+ Misses 30917 30423 -494
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
fix: consolidated report issue (cherry picked from commit 871cb11)
ankush
pushed a commit
that referenced
this pull request
Oct 20, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
fix: consolidated report issue (cherry picked from commit 871cb11) Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.