Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Taxes template for selling/buying doctypes #28048

Merged

Conversation

netchampfaris
Copy link
Contributor

@netchampfaris netchampfaris commented Oct 21, 2021

Depends on the new Print Format Builder

Do not merge until frappe/frappe#14134 is merged

How to test:

  1. Create a new Print format for any of Sales Invoice, Purchase Invoice, Sales Order, Purchase Order, Quotation, Supplier Quotation
  2. Now you should see a Sales Taxes and Charges (Field Template) in the sidebar. Drag it into the print format and see if it renders correctly.
  3. Profit.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #28048 (8b547e3) into develop (6019f60) will increase coverage by 0.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28048      +/-   ##
===========================================
+ Coverage    54.55%   55.17%   +0.62%     
===========================================
  Files         1248     1255       +7     
  Lines        67518    67871     +353     
===========================================
+ Hits         36836    37451     +615     
+ Misses       30682    30420     -262     
Impacted Files Coverage Δ
...ctype/product_tax_category/product_tax_category.py 0.00% <0.00%> (-100.00%) ⬇️
...rations/doctype/taxjar_settings/taxjar_settings.py 29.50% <0.00%> (-70.50%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-22.04%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/shopping_cart/utils.py 32.14% <0.00%> (-3.58%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.48% <0.00%> (-2.16%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
... and 69 more

@netchampfaris netchampfaris marked this pull request as ready for review October 28, 2021 07:02
@netchampfaris netchampfaris merged commit c8d0d9e into frappe:develop Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant