fix(minor): check if gst_category exists while validating GSTIN #28065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuja-pawar
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #28065 +/- ##
===========================================
+ Coverage 55.45% 55.50% +0.04%
===========================================
Files 1248 1248
Lines 67756 67758 +2
===========================================
+ Hits 37577 37611 +34
+ Misses 30179 30147 -32
|
deepeshgarg007
approved these changes
Nov 8, 2021
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 8, 2021
…-28065 fix(minor): check if gst_category exists while validating GSTIN (backport #28065)
|
@Mergifyio backport version-12-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 9, 2021
…-28065 fix(minor): check if gst_category exists while validating GSTIN (backport #28065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If you try adding GSTIN in Address for a Customer or Supplier from India in a non indian company, you would likely get following error unless you have gst_category custom field (which is created while setting up an indian company)