-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(India): GST category not getting auto updated #28459
Merged
deepeshgarg007
merged 2 commits into
frappe:version-13-hotfix
from
deepeshgarg007:gst_category_set_fix
Nov 19, 2021
Merged
fix(India): GST category not getting auto updated #28459
deepeshgarg007
merged 2 commits into
frappe:version-13-hotfix
from
deepeshgarg007:gst_category_set_fix
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport develop |
@Mergifyio backport version-12-hotfix |
🟠 Waiting for conditions to match
|
🟠 Waiting for conditions to match
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 19, 2021
fix(India): GST category not getting auto updated (backport #28459)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 19, 2021
…se/pr-28459 fix(India): GST category not getting auto updated (backport #28459)
deepeshgarg007
added a commit
that referenced
this pull request
Dec 3, 2021
…-28459 fix(India): GST category not getting auto updated (backport #28459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #28065
GST Category for customer/supplier was not getting auto-updated on setting the Party GSTIN in the address master
The reason for this was that the check was looking for GST category field in address master and since it didn't had that field the GST category was not getting successfully updated
This PR fixes that issues