fix(general_ledger): Order by in case Group by Account #28093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix order_by_statement if filter group by: Group by Account
zeta17
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
ankush
changed the title
ankush
added
the
squash
ankush
reviewed
Oct 27, 2021
Codecov Report
@@ Coverage Diff @@
## develop #28093 +/- ##
===========================================
+ Coverage 55.14% 55.25% +0.10%
===========================================
Files 1255 1255
Lines 67927 67929 +2
===========================================
+ Hits 37458 37533 +75
+ Misses 30469 30396 -73
|
AfshanKhan
approved these changes
Oct 27, 2021
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Update general_ledger.py Fix order_by_statement if filter group by: Group by Account * chore: whitespace Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> (cherry picked from commit f24ed67)
✅ Backports have been created
|
AfshanKhan
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Update general_ledger.py Fix order_by_statement if filter group by: Group by Account * chore: whitespace Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> (cherry picked from commit f24ed67) Co-authored-by: hendrik <hendrik.zeta@gmail.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…frappe#28106) * Update general_ledger.py Fix order_by_statement if filter group by: Group by Account * chore: whitespace Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> (cherry picked from commit f24ed67) Co-authored-by: hendrik <hendrik.zeta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix order_by_statement if filter group by: Group by Account