Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor): add a filter to avoid send work anniversary reminders for zero year (backport #28092) #28096

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 27, 2021

This is an automatic backport of pull request #28092 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 8cad23b)
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #28096 (5d52899) into develop (6ec047c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28096      +/-   ##
===========================================
+ Coverage    55.17%   55.19%   +0.02%     
===========================================
  Files         1255     1255              
  Lines        67895    67895              
===========================================
+ Hits         37459    37477      +18     
+ Misses       30436    30418      -18     
Impacted Files Coverage Δ
erpnext/hr/doctype/employee/employee_reminders.py 76.47% <ø> (ø)
...payroll/doctype/income_tax_slab/income_tax_slab.py 85.71% <0.00%> (-14.29%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.00% <0.00%> (-3.23%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.20% <0.00%> (-1.44%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
... and 15 more

@ruchamahabal ruchamahabal merged commit 25d1c1c into develop Oct 27, 2021
@mergify mergify bot deleted the mergify/bp/develop/pr-28092 branch October 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants